Skip to content

Commit be22576

Browse files
authored
Merge pull request #789 from ymohdriz/branch_v2.0.1_Fix785
Fix for issue 785 (OpenAPIParser.readLocation fails when fetching valid Swagger 2.0 resource with AuthorizationValues provided)
2 parents c0ebb99 + 6e5fcbc commit be22576

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

modules/swagger-parser-v2-converter/src/main/java/io/swagger/v3/parser/converter/SwaggerConverter.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ public List<io.swagger.models.auth.AuthorizationValue> convert(List<Authorizatio
116116
v.setType(auth.getType());
117117
v.setValue(auth.getValue());
118118
v.setKeyName(auth.getKeyName());
119+
convertedAuth.add(v);
119120
}
120121
}
121122

modules/swagger-parser-v2-converter/src/test/java/io/swagger/parser/test/V2ConverterTest.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
import io.swagger.v3.oas.models.security.SecurityScheme;
1717
import io.swagger.v3.oas.models.tags.Tag;
1818
import io.swagger.v3.parser.converter.SwaggerConverter;
19+
import io.swagger.v3.parser.core.models.AuthorizationValue;
1920
import io.swagger.v3.parser.core.models.ParseOptions;
2021
import io.swagger.v3.parser.core.models.SwaggerParseResult;
2122
import org.testng.annotations.Test;
@@ -26,6 +27,7 @@
2627
import java.nio.file.Files;
2728
import java.nio.file.Paths;
2829
import java.util.ArrayList;
30+
import java.util.Arrays;
2931
import java.util.List;
3032
import java.util.Map;
3133

@@ -622,6 +624,15 @@ public void testIssue708() throws Exception {
622624
assertEquals(schema.getPattern(), "^[0-9]+$");
623625
}
624626

627+
@Test(description = "OpenAPIParser.readLocation fails when fetching valid Swagger 2.0 resource with AuthorizationValues provided")
628+
public void testIssue785() {
629+
AuthorizationValue apiKey = new AuthorizationValue("api_key", "special-key", "header");
630+
List<AuthorizationValue> authorizationValues = Arrays.asList(apiKey);
631+
SwaggerConverter converter = new SwaggerConverter();
632+
List<io.swagger.models.auth.AuthorizationValue> convertedAuthList = converter.convert(authorizationValues);
633+
assertEquals(convertedAuthList.size(), authorizationValues.size());
634+
}
635+
625636
@Test(description = "OpenAPI v2 converter - Migrate a schema with AllOf")
626637
public void testIssue740() throws Exception {
627638
final OpenAPI oas = getConvertedOpenAPIFromJsonFile(ISSUE_740_YAML);

0 commit comments

Comments
 (0)