chore: revert to getopts for argument parsing

Author: Scandiravian

Cargo.lock

@@ -7,8 +7,8 @@ license = "MIT"
 repository = "https://github.com/swellaby/rusty-hook"
 readme = "README.md"
 edition = "2018"
-keywords = [ "hooks", "githook", "git", "hook", "commit" ]
-categories = [ "development-tools" ]
+keywords = ["hooks", "githook", "git", "hook", "commit"]
+categories = ["development-tools"]
 exclude = [
   ".coverage/**",
   ".testresults/**",
@@ -32,16 +32,16 @@ exclude = [
 
 [dependencies]
 ci_info = "0.14.2"
-clap = "3.0.0-beta.4"
-toml = "0.5.8"
+getopts = "0.2.21"
 nias = "0.7.0"
+toml = "0.5.8"
 
 [build-dependencies]
 ci_info = "0.14.2"
 toml = "0.5.8"
 nias = "0.7.0"
 
 [badges]
-azure-devops = { project = "swellaby/opensource", pipeline = "rusty-hook.linux-pr", build="49" }
+azure-devops = { project = "swellaby/opensource", pipeline = "rusty-hook.linux-pr", build = "49" }
 codecov = { repository = "swellaby/rusty-hook", branch = "master", service = "github" }
 maintenance = { status = "actively-developed" }

Cargo.toml

@@ -2,8 +2,8 @@
 #[path = "src/rusty_hook.rs"]
 mod rusty_hook;
 
+use std::env;
 use std::process::exit;
-use std::{env, vec};
 
 fn main() {
     if ci_info::is_ci() {
@@ -16,7 +16,7 @@ fn main() {
         nias::get_file_writer(),
         nias::get_file_existence_checker(),
         Some(&target_directory),
-        vec![],
+        &[],
     ) {
         println!(
             "Fatal error encountered during initialization. Details: {}",

build.rs

@@ -47,7 +47,7 @@ pub fn setup_hooks<F, G>(
     run_command: F,
     write_file: G,
     root_directory_path: &str,
-    hook_file_skip_list: &[&str],
+    hook_file_skip_list: &[String],
 ) -> Result<(), String>
 where
     F: Fn(

src/git.rs

@@ -22,5 +22,5 @@ else
 fi
 
 # shellcheck disable=SC2046
-rusty-hook run --hook "${hookName}" $([ -z "$gitParams" ] && echo "" || echo "-- $gitParams")
+rusty-hook run --hook "${hookName}" "${gitParams}"
 handleRustyHookCliResult $? "${hookName}"

src/hook_files/hook_script.sh

@@ -67,15 +67,15 @@ pub fn create_hook_files<F>(
     write_file: F,
     root_directory_path: &str,
     hooks_directory: &str,
-    hook_file_skip_list: &[&str],
+    hook_file_skip_list: &[String],
 ) -> Result<(), String>
 where
     F: Fn(&str, &str, bool) -> Result<(), String>,
 {
     let hook_file_contents = get_hook_file_contents();
     for hook in HOOK_NAMES
         .iter()
-        .filter(|h| !hook_file_skip_list.contains(h))
+        .filter(|h| !hook_file_skip_list.contains(&h.to_string()))
     {
         let path = get_file_path(root_directory_path, hooks_directory, hook);
         if write_file(&path, &hook_file_contents, true).is_err() {

src/hooks.rs

@@ -221,7 +221,12 @@ mod create_hook_files_tests {
             assert!(make_executable);
             Ok(())
         };
-        let result = create_hook_files(write_file, root_dir, git_hooks, &[EXP_SKIPPED_HOOK]);
+        let result = create_hook_files(
+            write_file,
+            root_dir,
+            git_hooks,
+            &[String::from(EXP_SKIPPED_HOOK)],
+        );
         assert_eq!(result, Ok(()));
     }
 }