Skip to content

Regroup headers instead of preserving them #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Regroup headers instead of preserving them #155

wants to merge 1 commit into from
+34 −34

Conversation

armallen
Copy link
Contributor

Using Preserve, this header list:

#include <memory>

#include <orion_engine/integrity_preprocessor/read_yaml_configuration.h>
#include <orion_engine/orion/create_integrity_preprocessor.h>

#include <orion_engine/integrity_common/read_antex_file.h>
#include <orion_engine/integrity_preprocessor/create_integrity_preprocessor_from_config.h>
#include <public_types/logging.h>

#include <string>
#include <utility>

is valid and won't be reformatted.

Using Regroup, the list is reformatted to:

#include <orion_engine/integrity_common/read_antex_file.h>
#include <orion_engine/integrity_preprocessor/create_integrity_preprocessor_from_config.h>
#include <orion_engine/integrity_preprocessor/read_yaml_configuration.h>
#include <orion_engine/orion/create_integrity_preprocessor.h>
#include <public_types/logging.h>

#include <memory>
#include <string>
#include <utility>

@armallen armallen requested a review from a team as a code owner June 18, 2025 08:16
sbmueller
sbmueller requested changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@sbmueller sbmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a change request for this PR, but I think we still need to

  1. Publicly announce the change and ask for opinions
  2. Update the guidelines with the new behavior

clang_format/.clang-format
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Which formatter did you use for this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be redhat.vscode-yaml VSCode extension https://marketplace.visualstudio.com/items?itemName=redhat.vscode-yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbmueller sbmueller sbmueller requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armallen @sbmueller