Skip to content

Commit 4669958

Browse files
authored
jextract/jni: use deferEnvironment instead of environment interface (#437)
1 parent e907ab0 commit 4669958

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+NativeTranslation.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -973,7 +973,7 @@ extension JNISwift2JavaGenerator {
973973
// Defer might on any thread, so we need to attach environment.
974974
printer.print("let deferEnvironment = try! JavaVirtualMachine.shared().environment()")
975975
for globalRef in globalRefs {
976-
printer.print("environment.interface.DeleteGlobalRef(deferEnvironment, \(globalRef))")
976+
printer.print("deferEnvironment.interface.DeleteGlobalRef(deferEnvironment, \(globalRef))")
977977
}
978978
}
979979
if isThrowing {

Tests/JExtractSwiftTests/JNI/JNIAsyncTests.swift

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ struct JNIAsyncTests {
6666
var environment = environment!
6767
defer {
6868
let deferEnvironment = try! JavaVirtualMachine.shared().environment()
69-
environment.interface.DeleteGlobalRef(deferEnvironment, globalFuture)
69+
deferEnvironment.interface.DeleteGlobalRef(deferEnvironment, globalFuture)
7070
}
7171
let swiftResult$ = await SwiftModule.asyncVoid()
7272
environment = try! JavaVirtualMachine.shared().environment()
@@ -79,7 +79,7 @@ struct JNIAsyncTests {
7979
var environment = try! JavaVirtualMachine.shared().environment()
8080
defer {
8181
let deferEnvironment = try! JavaVirtualMachine.shared().environment()
82-
environment.interface.DeleteGlobalRef(deferEnvironment, globalFuture)
82+
deferEnvironment.interface.DeleteGlobalRef(deferEnvironment, globalFuture)
8383
}
8484
let swiftResult$ = await SwiftModule.asyncVoid()
8585
environment = try! JavaVirtualMachine.shared().environment()
@@ -140,7 +140,7 @@ struct JNIAsyncTests {
140140
var environment = environment!
141141
defer {
142142
let deferEnvironment = try! JavaVirtualMachine.shared().environment()
143-
environment.interface.DeleteGlobalRef(deferEnvironment, globalFuture)
143+
deferEnvironment.interface.DeleteGlobalRef(deferEnvironment, globalFuture)
144144
}
145145
do {
146146
let swiftResult$ = await try SwiftModule.async()
@@ -160,7 +160,7 @@ struct JNIAsyncTests {
160160
var environment = try! JavaVirtualMachine.shared().environment()
161161
defer {
162162
let deferEnvironment = try! JavaVirtualMachine.shared().environment()
163-
environment.interface.DeleteGlobalRef(deferEnvironment, globalFuture)
163+
deferEnvironment.interface.DeleteGlobalRef(deferEnvironment, globalFuture)
164164
}
165165
do {
166166
let swiftResult$ = await try SwiftModule.async()
@@ -228,7 +228,7 @@ struct JNIAsyncTests {
228228
var environment = environment!
229229
defer {
230230
let deferEnvironment = try! JavaVirtualMachine.shared().environment()
231-
environment.interface.DeleteGlobalRef(deferEnvironment, globalFuture)
231+
deferEnvironment.interface.DeleteGlobalRef(deferEnvironment, globalFuture)
232232
}
233233
let swiftResult$ = await SwiftModule.async(i: Int64(fromJNI: i, in: environment))
234234
environment = try! JavaVirtualMachine.shared().environment()
@@ -242,7 +242,7 @@ struct JNIAsyncTests {
242242
var environment = try! JavaVirtualMachine.shared().environment()
243243
defer {
244244
let deferEnvironment = try! JavaVirtualMachine.shared().environment()
245-
environment.interface.DeleteGlobalRef(deferEnvironment, globalFuture)
245+
deferEnvironment.interface.DeleteGlobalRef(deferEnvironment, globalFuture)
246246
}
247247
let swiftResult$ = await SwiftModule.async(i: Int64(fromJNI: i, in: environment))
248248
environment = try! JavaVirtualMachine.shared().environment()
@@ -319,7 +319,7 @@ struct JNIAsyncTests {
319319
var environment = environment!
320320
defer {
321321
let deferEnvironment = try! JavaVirtualMachine.shared().environment()
322-
environment.interface.DeleteGlobalRef(deferEnvironment, globalFuture)
322+
deferEnvironment.interface.DeleteGlobalRef(deferEnvironment, globalFuture)
323323
}
324324
let swiftResult$ = await SwiftModule.async(c: c$.pointee)
325325
environment = try! JavaVirtualMachine.shared().environment()
@@ -336,7 +336,7 @@ struct JNIAsyncTests {
336336
var environment = try! JavaVirtualMachine.shared().environment()
337337
defer {
338338
let deferEnvironment = try! JavaVirtualMachine.shared().environment()
339-
environment.interface.DeleteGlobalRef(deferEnvironment, globalFuture)
339+
deferEnvironment.interface.DeleteGlobalRef(deferEnvironment, globalFuture)
340340
}
341341
let swiftResult$ = await SwiftModule.async(c: c$.pointee)
342342
environment = try! JavaVirtualMachine.shared().environment()
@@ -397,8 +397,8 @@ struct JNIAsyncTests {
397397
...
398398
defer {
399399
let deferEnvironment = try! JavaVirtualMachine.shared().environment()
400-
environment.interface.DeleteGlobalRef(deferEnvironment, globalFuture)
401-
environment.interface.DeleteGlobalRef(deferEnvironment, s)
400+
deferEnvironment.interface.DeleteGlobalRef(deferEnvironment, globalFuture)
401+
deferEnvironment.interface.DeleteGlobalRef(deferEnvironment, s)
402402
}
403403
...
404404
environment.interface.CallBooleanMethodA(environment, globalFuture, _JNIMethodIDCache.CompletableFuture.complete, [jvalue(l: swiftResult$.getJNIValue(in: environment))])

0 commit comments

Comments
 (0)