test helpers: do not use default build system

Many of the executeSwift* command helpers accept a build system
provider, which was defaulted to the native build system.  Since we are
augmenting the tests to also run against the SwiftBuild, setting a
default value may lead to an undesirable test behaviour.

Update all the executeSwift* commands to no set a default build system
provider, and update SwiftBuild tests accordingly.

Author: bkhouri

Fixtures/Miscellaneous/Unicode/Package.swift

@@ -13,7 +13,7 @@ let complicatedString = "πשּׁµ𝄞🇺🇳🇮🇱x̱̱̱̱̱̄̄̄̄̄"
 // 🇮🇱 U+1F1EE U+1F1F1: Second consecutive regional indicator. (Complicated grapheme breaking.)
 // x̱̱̱̱̱̄̄̄̄̄ U+0078 (U+0331 U+0304) × 5: Extremely long combining sequence. (Also reordrant under normalization.)
 
-// The following verifies that sources haven’t been normalized, which would reduce the test’s effectiveness.
+// The following verifies that sources haven't been normalized, which would reduce the test's effectiveness.
 var verify = "\u{03C0}\u{0FB2C}\u{00B5}\u{1D11E}\u{1F1FA}\u{1F1F3}\u{1F1EE}\u{1F1F1}\u{0078}\u{0331}\u{0304}\u{0331}\u{0304}\u{0331}\u{0304}\u{0331}\u{0304}\u{0331}\u{0304}"
 assert(
     complicatedString.unicodeScalars.elementsEqual(verify.unicodeScalars),

Sources/Commands/PackageCommands/PluginCommand.swift

@@ -157,11 +157,11 @@ struct PluginCommand: AsyncSwiftCommand {
             }
             for plugin in allPlugins.sorted(by: { $0.name < $1.name }) {
                 guard case .command(let intent, _) = plugin.capability else { continue }
-                var line = "‘\(intent.invocationVerb)’ (plugin ‘\(plugin.name)’"
+                var line = "'\(intent.invocationVerb)' (plugin '\(plugin.name)'"
                 if let package = packageGraph.packages
                     .first(where: { $0.modules.contains(where: { $0.name == plugin.name }) })
                 {
-                    line += " in package ‘\(package.manifest.displayName)’"
+                    line += " in package '\(package.manifest.displayName)'"
                 }
                 line += ")"
                 print(line)
@@ -186,14 +186,14 @@ struct PluginCommand: AsyncSwiftCommand {
         // Load the workspace and resolve the package graph.
         let packageGraph = try await swiftCommandState.loadPackageGraph()
 
-        swiftCommandState.observabilityScope.emit(info: "Finding plugin for command ‘\(command)’")
+        swiftCommandState.observabilityScope.emit(info: "Finding plugin for command '\(command)'")
         let matchingPlugins = PluginCommand.findPlugins(matching: command, in: packageGraph, limitedTo: options.packageIdentity)
 
         // Complain if we didn't find exactly one.
         if matchingPlugins.isEmpty {
-            throw ValidationError("Unknown subcommand or plugin name ‘\(command)’")
+            throw ValidationError("Unknown subcommand or plugin name '\(command)'")
         } else if matchingPlugins.count > 1 {
-            throw ValidationError("\(matchingPlugins.count) plugins found for ‘\(command)’")
+            throw ValidationError("\(matchingPlugins.count) plugins found for '\(command)'")
         }
 
         // handle plugin execution arguments that got passed after the plugin name
@@ -242,7 +242,7 @@ struct PluginCommand: AsyncSwiftCommand {
         let pluginsDir = try swiftCommandState.getActiveWorkspace().location.pluginWorkingDirectory
             .appending(component: plugin.name)
 
-        // The `cache` directory is in the plugin’s directory and is where the plugin script runner caches compiled plugin binaries and any other derived information for this plugin.
+        // The `cache` directory is in the plugin's directory and is where the plugin script runner caches compiled plugin binaries and any other derived information for this plugin.
         let pluginScriptRunner = try swiftCommandState.getPluginScriptRunner(
             customPluginsDir: pluginsDir
         )
@@ -291,7 +291,7 @@ struct PluginCommand: AsyncSwiftCommand {
                         "--allow-network-connections \(PluginCommand.PluginOptions.NetworkPermission(scope).remedyDescription)"
                 }
 
-                let problem = "Plugin ‘\(plugin.name)’ wants permission to \(permissionString)."
+                let problem = "Plugin '\(plugin.name)' wants permission to \(permissionString)."
                 let reason = "Stated reason: “\(reasonString)”."
                 if swiftCommandState.outputStream.isTTY {
                     // We can ask the user directly, so we do so.

Sources/CoreCommands/Options.swift

@@ -454,15 +454,15 @@ public struct BuildOptions: ParsableArguments {
         )
     }
 
-    /// The compilation destination’s target triple.
+    /// The compilation destination's target triple.
     @Option(name: .customLong("triple"), transform: Triple.init)
     public var customCompileTriple: Triple?
 
-    /// Path to the compilation destination’s SDK.
+    /// Path to the compilation destination's SDK.
     @Option(name: .customLong("sdk"))
     public var customCompileSDK: AbsolutePath?
 
-    /// Path to the compilation destination’s toolchain.
+    /// Path to the compilation destination's toolchain.
     @Option(name: .customLong("toolchain"))
     public var customCompileToolchain: AbsolutePath?
 

Sources/PackageCollectionsModel/PackageCollectionModel+v1.swift

@@ -186,7 +186,7 @@ extension PackageCollectionModel.V1.Collection.Package {
             /// An array of the package version's products.
             public let products: [PackageCollectionModel.V1.Product]
 
-            /// An array of the package version’s supported platforms specified in `Package.swift`.
+            /// An array of the package version's supported platforms specified in `Package.swift`.
             public let minimumPlatformVersions: [PackageCollectionModel.V1.PlatformVersion]?
 
             /// Creates a `Manifest`
@@ -239,7 +239,7 @@ extension PackageCollectionModel.V1 {
         /// The product type.
         public let type: ProductType
 
-        /// An array of the product’s targets.
+        /// An array of the product's targets.
         public let targets: [String]
 
         /// Creates a `Product`

Sources/PackageCollectionsSigning/CertificatePolicy.swift

@@ -123,8 +123,8 @@ enum CertificatePolicyError: Error, Equatable {
 /// Default policy for validating certificates used to sign package collections.
 ///
 /// Certificates must satisfy these conditions:
-///   - The timestamp at which signing/verification is done must fall within the signing certificate’s validity period.
-///   - The certificate’s “Extended Key Usage” extension must include “Code Signing”.
+///   - The timestamp at which signing/verification is done must fall within the signing certificate's validity period.
+///   - The certificate's “Extended Key Usage” extension must include “Code Signing”.
 ///   - The certificate must use either 256-bit EC (recommended) or 2048-bit RSA key.
 ///   - The certificate must not be revoked. The certificate authority must support OCSP.
 ///   - The certificate chain is valid and root certificate must be trusted.

Sources/PackageGraph/ModulesGraph.swift

@@ -374,7 +374,7 @@ extension PackageGraphError: CustomStringConvertible {
                 }
                 return description
             }
-            return "multiple packages (\(packagesDescriptions.joined(separator: ", "))) declare products with a conflicting name: '\(product)’; product names need to be unique across the package graph"
+            return "multiple packages (\(packagesDescriptions.joined(separator: ", "))) declare products with a conflicting name: '\(product)'; product names need to be unique across the package graph"
         case .multipleModuleAliases(let target, let product, let package, let aliases):
             return "multiple aliases: ['\(aliases.joined(separator: "', '"))'] found for target '\(target)' in product '\(product)' from package '\(package)'"
         case .unsupportedPluginDependency(let targetName, let dependencyName, let dependencyType,  let dependencyPackage):

Sources/PackageGraph/PackageModel+Extensions.swift

@@ -64,7 +64,7 @@ extension PackageContainerConstraint {
         case .specific:
             switch products {
             case .everything:
-                assertionFailure("Attempted to enumerate a root package’s product filter; root packages have no filter.")
+                assertionFailure("Attempted to enumerate a root package's product filter; root packages have no filter.")
                 return []
             case .specific(let set):
                 if set.isEmpty { // Pointing at the package without a particular product.

Sources/PackageGraph/Resolution/DependencyResolutionNode.swift

@@ -104,7 +104,7 @@ public enum DependencyResolutionNode {
     ///
     /// This is the constraint that requires all products from a package resolve to the same version.
     internal func versionLock(version: Version) -> PackageContainerConstraint? {
-        // Don’t create a version lock for anything but a product.
+        // Don't create a version lock for anything but a product.
         guard specificProduct != nil else { return nil }
         return PackageContainerConstraint(
             package: self.package,
@@ -118,7 +118,7 @@ public enum DependencyResolutionNode {
     ///
     /// This is the constraint that requires all products from a package resolve to the same revision.
     internal func revisionLock(revision: String) -> PackageContainerConstraint? {
-        // Don’t create a revision lock for anything but a product.
+        // Don't create a revision lock for anything but a product.
         guard specificProduct != nil else { return nil }
         return PackageContainerConstraint(
             package: self.package,

Sources/PackageLoading/PackageBuilder.swift

@@ -111,7 +111,7 @@ extension ModuleError: CustomStringConvertible {
         switch self {
         case .duplicateModule(let target, let packages):
             let packages = packages.map(\.description).sorted().joined(separator: "', '")
-            return "multiple packages ('\(packages)') declare targets with a conflicting name: '\(target)’; target names need to be unique across the package graph"
+            return "multiple packages ('\(packages)') declare targets with a conflicting name: '\(target)'; target names need to be unique across the package graph"
         case .moduleNotFound(let target, let type, let shouldSuggestRelaxedSourceDir):
             let folderName = (type == .test) ? "Tests" : (type == .plugin) ? "Plugins" : "Sources"
             var clauses = ["Source files for target \(target) should be located under '\(folderName)/\(target)'"]

Sources/PackageModel/Manifest/Manifest.swift

@@ -519,7 +519,7 @@ public final class Manifest: Sendable {
                     registry: &registry.known,
                     availablePackages: availablePackages
                 ) {
-                    // If it doesn’t match a package, it should be a target, not a product.
+                    // If it doesn't match a package, it should be a target, not a product.
                     if self.targets.contains(where: { $0.name == product }) {
                         break
                     } else {