Update based on PR feedback

Author: bkhouri

Sources/Build/BuildOperation.swift

@@ -399,7 +399,6 @@ public final class BuildOperation: PackageStructureDelegate, SPMBuildCore.BuildS
     public func build(subset: BuildSubset, buildOutputs: [BuildOutput]) async throws -> BuildResult {
         var result = BuildResult(
             serializedDiagnosticPathsByTargetName: .failure(StringError("Building was skipped")),
-            packageGraph: try await self.getPackageGraph(),
             replArguments: nil,
         )
 
@@ -464,7 +463,6 @@ public final class BuildOperation: PackageStructureDelegate, SPMBuildCore.BuildS
 
         result = BuildResult(
             serializedDiagnosticPathsByTargetName: result.serializedDiagnosticPathsByTargetName,
-            packageGraph: result.packageGraph,
             symbolGraph: result.symbolGraph,
             buildPlan: buildResultBuildPlan,
             replArguments: buildResultReplArgs,

Sources/SPMBuildCore/BuildSystem/BuildSystem.swift

@@ -97,20 +97,17 @@ public typealias CLIArguments = [String]
 public struct BuildResult {
     package init(
         serializedDiagnosticPathsByTargetName: Result<[String: [AbsolutePath]], Error>,
-        packageGraph: ModulesGraph,
         symbolGraph: SymbolGraphResult? = nil,
         buildPlan: BuildPlan? = nil,
         replArguments: CLIArguments?
     ) {
         self.serializedDiagnosticPathsByTargetName = serializedDiagnosticPathsByTargetName
-        self.packageGraph = packageGraph
         self.symbolGraph = symbolGraph
         self.buildPlan = buildPlan
         self.replArguments = replArguments
     }
 
     public let replArguments: CLIArguments?
-    public let packageGraph: ModulesGraph
     public let symbolGraph: SymbolGraphResult?
     public let buildPlan: BuildPlan?
 

Sources/SwiftBuildSupport/SwiftBuildSystem.swift

@@ -345,7 +345,6 @@ public final class SwiftBuildSystem: SPMBuildCore.BuildSystem {
         guard !buildParameters.shouldSkipBuilding else {
             return BuildResult(
                 serializedDiagnosticPathsByTargetName: .failure(StringError("Building was skipped")),
-                packageGraph: try await self.getPackageGraph(),
                 replArguments: nil,
             )
         }
@@ -588,7 +587,6 @@ public final class SwiftBuildSystem: SPMBuildCore.BuildSystem {
 
             return BuildResult(
                 serializedDiagnosticPathsByTargetName: .success(serializedDiagnosticPathsByTargetName),
-                packageGraph: try await self.getPackageGraph(),
                 symbolGraph: SymbolGraphResult(
                     outputLocationForTarget: { target, buildParameters in
                         return ["\(buildParameters.triple.archName)", "\(target).symbolgraphs"]

Sources/XCBuildSupport/XcodeBuildSystem.swift

@@ -163,7 +163,6 @@ public final class XcodeBuildSystem: SPMBuildCore.BuildSystem {
     public func build(subset: BuildSubset, buildOutputs: [BuildOutput]) async throws -> BuildResult {
         let buildResult = BuildResult(
             serializedDiagnosticPathsByTargetName: .failure(StringError("XCBuild does not support reporting serialized diagnostics.")),
-            packageGraph: try await self.getPackageGraph(),
             replArguments: nil,
         )