Basics: remove @testable imports
#8821
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
shawnhyam
as code owners
|
@swift-ci please test |
bkhouri
approved these changes
Jun 13, 2025
jakepetroules
approved these changes
Jun 13, 2025
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
@swift-ci please test |
|
@swift-ci test windows |
|
This change may conflict with #8826 |
Draft
|
@swift-ci test windows |
This extends the visibility of some of the private implementation to the package level to allow use for testing without `@testable` imports.
Use the newly extended APIs for testing and use a non-testable import of the package, avoiding a recompilation.
|
Closing this in favour of #8826 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the build to open up some of the private APIs to the package and remove the use of
@testablefor the Basics module in the tests.