SwiftBuildSupport: Revert patch required when we were using '#if canImport(SwiftBuild)' checks #8957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmattos
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
shawnhyam
as code owners
pmattos
changed the title
|
@swift-ci test |
pmattos
commented
Jul 18, 2025
| static func targetName(forProductName name: String, suffix: TargetSuffix? = nil) -> String { | ||
| return SwiftBuildSupport.targetName(forProductName: name, suffix: suffix?.rawValue) | ||
| let suffix = suffix?.rawValue ?? "" | ||
| return "\(name)\(suffix)-product" |
There was a problem hiding this comment.
This is the main change! The rest is just some quick refactorings...
jakepetroules
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We couldn't call
SwiftBuildSupport.PackagePIFBuilderfromSwiftBuildSupport/BuildSystem.swiftgiven the prior#if canImport(SwiftBuild)checks in former. This is no longer the case.Modifications:
Provides a minor code cleanup in
PackagePIFBuilder+Helpers.swift.This is tracked by: rdar://139545019