Add tags to Swift Testing Tests #9292
Conversation
bkhouri
requested review from
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand,
rconnell9 and
shawnhyam
as code owners
|
@swift-ci test |
bkhouri
force-pushed
the
t/main/gh9287_rdar163484107_command_line_feature_parity
branch
from
5951fe8 to
3ab4cbe
Compare
|
@swift-ci test |
|
@swift-ci test windows |
bkhouri
force-pushed
the
t/main/gh9287_rdar163484107_command_line_feature_parity
branch
from
3ab4cbe to
d7b534f
Compare
|
@swift-ci test |
|
@swift-ci test windows |
| /// Which compile-time sanitizers should be enabled. | ||
| @Option( | ||
| name: .customLong("sanitize"), | ||
| help: "Turn on runtime checks for erroneous behavior, possible values: \(Sanitizer.formattedValues)." |
There was a problem hiding this comment.
Was this accidentally added from a different PR?
There was a problem hiding this comment.
it was not. swift argument parser library lists the possible values, so the redundant text was removed.
| .Feature.CommandLineArguments.Configuration, | ||
| ), | ||
| .tags( | ||
| .Feature.CommandLineArguments.VeryVerbose, |
There was a problem hiding this comment.
These tags feel very fine-grained and hard to individually maintain, should we use something more general?
There was a problem hiding this comment.
These tags are currently being used to determine command line feature parity between SwiftBuild and native build system.
| .SWBINTTODO("Test fails because the dummy-swiftc used in the test isn't accepted by swift-build. This needs to be investigated"), | ||
| arguments: getBuildData(for: SupportedBuildSystemOnPlatform), | ||
| .tags( | ||
| .Feature.EnvironmentVariables.SWIFT_EXEC, |
There was a problem hiding this comment.
Same question here, I'm not 100% convinced tags for individual env vars makes sense
There was a problem hiding this comment.
I would tend to agree, but we need to track the feature parity between native and SwiftBuild. This is one way to track which environment variables are added.
|
@swift-ci test self hosted windows |
bkhouri
deleted the
t/main/gh9287_rdar163484107_command_line_feature_parity
branch
2 participants
relates to: #9287