Skip to content

Commit a63f457

Browse files
committed
Enable the verify documentation GitHub Action check
And remove the corresponding subcommand from `swift-syntax-dev-utils`. Fixes #2987
1 parent 61caf25 commit a63f457

File tree

4 files changed

+3
-95
lines changed

4 files changed

+3
-95
lines changed

.github/workflows/pull_request.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,9 @@ jobs:
1616
uses: swiftlang/github-workflows/.github/workflows/soundness.yml@main
1717
with:
1818
license_header_check_project_name: "Swift.org"
19+
docs_check_additional_arguments: "--disable-parameters-and-returns-validation"
1920
# https://github.com/swiftlang/swift-syntax/issues/2986
2021
api_breakage_check_enabled: false
21-
# https://github.com/swiftlang/swift-syntax/issues/2987
22-
docs_check_enabled: false
2322
# https://github.com/swiftlang/swift-syntax/issues/2988
2423
format_check_enabled: false
2524
# https://github.com/swiftlang/swift-syntax/issues/2989

Sources/SwiftParser/StringLiteralRepresentedLiteralValue.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,8 @@ extension StringSegmentSyntax {
8383
precondition(!hasError, "appendUnescapedLiteralValue relies on properly parsed literals")
8484

8585
let rawText = content.rawText
86-
if !rawText.contains("\\") {
87-
// Fast path. No escape sequence.
86+
if !rawText.contains(where: { $0 == "\\" || $0 == "\r" }) {
87+
// Fast path. No escape sequence that need to be interpreted or \r\n that need to be normalized to \n.
8888
output.append(String(syntaxText: rawText))
8989
return
9090
}

SwiftSyntaxDevUtils/Sources/swift-syntax-dev-utils/SwiftSyntaxDevUtils.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ struct SwiftSyntaxDevUtils: ParsableCommand {
3030
GenerateSourceCode.self,
3131
LocalPrPrecheck.self,
3232
Test.self,
33-
VerifyDocumentation.self,
3433
VerifySourceCode.self,
3534
]
3635
)

SwiftSyntaxDevUtils/Sources/swift-syntax-dev-utils/commands/VerifyDocumentation.swift

Lines changed: 0 additions & 90 deletions
This file was deleted.

0 commit comments

Comments
 (0)