Skip to content

Commit a119b25

Browse files
Revert "Merge pull request #83135 from MaxDesiatov/test-wasm-stdlib"
This reverts commit 44a6811, reversing changes made to 4d8b589.
1 parent 928de05 commit a119b25

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

utils/build_swift/build_swift/driver_arguments.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -292,9 +292,6 @@ def _apply_default_arguments(args):
292292
args.test_xros_host = False
293293
args.test_android_host = False
294294

295-
if args.build_wasmstdlib:
296-
args.test_wasmstdlib = True
297-
298295

299296
def create_argument_parser():
300297
"""Return a configured argument parser."""
@@ -832,8 +829,6 @@ def create_argument_parser():
832829
option(['--build-wasm-stdlib'], toggle_true('build_wasmstdlib'),
833830
help='build the stdlib for WebAssembly target into a'
834831
'separate build directory ')
835-
option('--test-wasm-stdlib', toggle_true('test_wasmstdlib'),
836-
help='test stdlib for WebAssembly')
837832
option(['--wasmkit'], toggle_true('build_wasmkit'),
838833
help='build WasmKit')
839834
option(['--install-wasmkit'], toggle_true('install_wasmkit'),

utils/build_swift/tests/expected_options.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@
328328
'test_swiftformat': False,
329329
'test_swiftdocc': False,
330330
'test_toolchainbenchmarks': False,
331-
'test_wasmstdlib': False,
331+
'test_wasmstdlib': True,
332332
'tvos': False,
333333
'tvos_all': False,
334334
'validation_test': None,
@@ -591,7 +591,6 @@ class BuildScriptImplOption(_BaseOption):
591591
SetTrueOption('--swiftdocc', dest='build_swiftdocc'),
592592
SetTrueOption('--build-minimal-stdlib', dest='build_minimalstdlib'),
593593
SetTrueOption('--build-wasm-stdlib', dest='build_wasmstdlib'),
594-
SetTrueOption('--test-wasm-stdlib', dest='test_wasmstdlib'),
595594
SetTrueOption('--wasmkit', dest='build_wasmkit'),
596595
SetTrueOption('--build-stdlib-docs'),
597596
SetTrueOption('--preview-stdlib-docs'),

utils/swift_build_support/swift_build_support/build_script_invocation.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -683,9 +683,7 @@ def compute_product_pipelines(self):
683683
builder.add_product(products.WasmKit,
684684
is_enabled=self.args.build_wasmkit)
685685
builder.add_product(products.WasmStdlib,
686-
# Revert `or self.args.test_wasmstdlib` once we adopt `wasi-sdk-26`
687-
# or higher version that includes https://github.com/WebAssembly/wasi-libc/commit/eadb436d5c09f7983c3a687086e5af6b6e9f5510.patch
688-
is_enabled=self.args.build_wasmstdlib or self.args.test_wasmstdlib)
686+
is_enabled=self.args.build_wasmstdlib)
689687
builder.add_product(products.WasmThreadsStdlib,
690688
is_enabled=self.args.build_wasmstdlib)
691689
builder.add_product(products.WasmSwiftSDK,

0 commit comments

Comments
 (0)