Revert "[Observation] Ensure deinitialized Observable types don't leave active observations in memory (#82752)" #83492
+4
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve active observations in memory (swiftlang#82752)" This reverts commit a349e64.
hborla
approved these changes
Aug 1, 2025
|
@swift-ci please test and merge |
|
@swift-ci please test |
5 tasks
|
@phausler Can you please provide context on this revert? The original PR seemed like it was providing a good bug fix. |
|
@stephencelis It is a good bug fix, but unfortunately broke some things that were depending on the misbehavior in interesting ways. We're investigating some workarounds that we think will enable us to re-land this change in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a349e64.
This is in concert of #83436