Skip to content

Commit 65b96e3

Browse files
committed
minor #724 [Store] Do not finalize the classes anymore (lyrixx)
This PR was merged into the main branch. Discussion ---------- [Store] Do not finalize the classes anymore | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Docs? | no | Issues | Fix #366 (comment) | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Commits ------- 3b89731 [Store] Do not finalize the classes anymore
2 parents 0b2a28c + 3b89731 commit 65b96e3

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

src/store/src/Bridge/ClickHouse/Store.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,12 @@
2525
/**
2626
* @author Grégoire Pineau <[email protected]>
2727
*/
28-
final readonly class Store implements ManagedStoreInterface, StoreInterface
28+
class Store implements ManagedStoreInterface, StoreInterface
2929
{
3030
public function __construct(
31-
private HttpClientInterface $httpClient,
32-
private string $databaseName = 'default',
33-
private string $tableName = 'embedding',
31+
private readonly HttpClientInterface $httpClient,
32+
private readonly string $databaseName = 'default',
33+
private readonly string $tableName = 'embedding',
3434
) {
3535
}
3636

src/store/src/Bridge/Local/InMemoryStore.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
/**
2121
* @author Guillaume Loulier <[email protected]>
2222
*/
23-
final class InMemoryStore implements ManagedStoreInterface, StoreInterface
23+
class InMemoryStore implements ManagedStoreInterface, StoreInterface
2424
{
2525
/**
2626
* @var VectorDocument[]

src/store/src/Bridge/SurrealDb/Store.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
/**
2626
* @author Guillaume Loulier <[email protected]>
2727
*/
28-
final class Store implements ManagedStoreInterface, StoreInterface
28+
class Store implements ManagedStoreInterface, StoreInterface
2929
{
3030
private string $authenticationToken = '';
3131

0 commit comments

Comments
 (0)