Use JSON Path to convert responses

Author: chr-hertel

examples/composer.json

@@ -22,6 +22,7 @@
         "symfony/event-dispatcher": "^6.4|^7.0",
         "symfony/filesystem": "^6.4|^7.0",
         "symfony/finder": "^6.4|^7.0",
+        "symfony/json-path": "^7.3",
         "symfony/process": "^6.4|^7.0",
         "symfony/var-dumper": "^6.4|^7.0"
     },

src/platform/composer.json

@@ -28,6 +28,7 @@
         "psr/log": "^3.0",
         "symfony/clock": "^6.4 || ^7.1",
         "symfony/http-client": "^6.4 || ^7.1",
+        "symfony/json-path": "^7.3",
         "symfony/property-access": "^6.4 || ^7.1",
         "symfony/property-info": "^6.4 || ^7.1",
         "symfony/serializer": "^6.4 || ^7.1",

src/platform/src/Bridge/Azure/OpenAI/PlatformFactory.php

@@ -11,7 +11,6 @@
 
 namespace Symfony\AI\Platform\Bridge\Azure\OpenAI;
 
-use Symfony\AI\Platform\Bridge\OpenAI\Embeddings;
 use Symfony\AI\Platform\Bridge\OpenAI\GPT\ResponseConverter;
 use Symfony\AI\Platform\Bridge\OpenAI\Whisper\AudioNormalizer;
 use Symfony\AI\Platform\Contract;
@@ -40,7 +39,7 @@ public static function create(
 
         return new Platform(
             [$GPTResponseFactory, $embeddingsResponseFactory, $whisperResponseFactory],
-            [new ResponseConverter(), new Embeddings\ResponseConverter(), new \Symfony\AI\Platform\Bridge\OpenAI\Whisper\ResponseConverter()],
+            [new ResponseConverter(), new \Symfony\AI\Platform\Bridge\OpenAI\Whisper\ResponseConverter()],
             $contract ?? Contract::create(new AudioNormalizer()),
         );
     }

src/platform/src/Bridge/Google/Embeddings.php

@@ -32,6 +32,6 @@ class Embeddings extends Model
      */
     public function __construct(string $name = self::GEMINI_EMBEDDING_EXP_03_07, array $options = [])
     {
-        parent::__construct($name, [Capability::INPUT_MULTIPLE], $options);
+        parent::__construct($name, [Capability::INPUT_MULTIPLE, Capability::OUTPUT_VECTOR], $options);
     }
 }

src/platform/src/Bridge/Google/Embeddings/ResponseConverter.php

@@ -11,37 +11,15 @@
 
 namespace Symfony\AI\Platform\Bridge\Google\Embeddings;
 
-use Symfony\AI\Platform\Bridge\Google\Embeddings;
-use Symfony\AI\Platform\Exception\RuntimeException;
-use Symfony\AI\Platform\Model;
-use Symfony\AI\Platform\Response\VectorResponse;
-use Symfony\AI\Platform\ResponseConverterInterface;
-use Symfony\AI\Platform\Vector\Vector;
-use Symfony\Contracts\HttpClient\ResponseInterface;
+use Symfony\AI\Platform\Contract\ResponseConverter\VectorResponseConverter;
 
 /**
  * @author Valtteri R <[email protected]>
  */
-final readonly class ResponseConverter implements ResponseConverterInterface
+final readonly class ResponseConverter extends VectorResponseConverter
 {
-    public function supports(Model $model): bool
+    public function __construct()
     {
-        return $model instanceof Embeddings;
-    }
-
-    public function convert(ResponseInterface $response, array $options = []): VectorResponse
-    {
-        $data = $response->toArray();
-
-        if (!isset($data['embeddings'])) {
-            throw new RuntimeException('Response does not contain data');
-        }
-
-        return new VectorResponse(
-            ...array_map(
-                static fn (array $item): Vector => new Vector($item['values']),
-                $data['embeddings'],
-            ),
-        );
+        parent::__construct('$.embeddings[*].values');
     }
 }

src/platform/src/Bridge/Mistral/Embeddings.php

@@ -28,6 +28,6 @@ public function __construct(
         string $name = self::MISTRAL_EMBED,
         array $options = [],
     ) {
-        parent::__construct($name, [Capability::INPUT_MULTIPLE], $options);
+        parent::__construct($name, [Capability::INPUT_MULTIPLE, Capability::OUTPUT_VECTOR], $options);
     }
 }

src/platform/src/Bridge/Mistral/Embeddings/ResponseConverter.php

@@ -13,7 +13,6 @@
 
 use Symfony\AI\Platform\Bridge\Mistral\Contract\ToolNormalizer;
 use Symfony\AI\Platform\Bridge\Mistral\Embeddings\ModelClient as EmbeddingsModelClient;
-use Symfony\AI\Platform\Bridge\Mistral\Embeddings\ResponseConverter as EmbeddingsResponseConverter;
 use Symfony\AI\Platform\Bridge\Mistral\Llm\ModelClient as MistralModelClient;
 use Symfony\AI\Platform\Bridge\Mistral\Llm\ResponseConverter as MistralResponseConverter;
 use Symfony\AI\Platform\Contract;
@@ -36,7 +35,7 @@ public static function create(
 
         return new Platform(
             [new EmbeddingsModelClient($httpClient, $apiKey), new MistralModelClient($httpClient, $apiKey)],
-            [new EmbeddingsResponseConverter(), new MistralResponseConverter()],
+            [new MistralResponseConverter()],
             $contract ?? Contract::create(new ToolNormalizer()),
         );
     }

src/platform/src/Bridge/Mistral/PlatformFactory.php

@@ -11,6 +11,7 @@
 
 namespace Symfony\AI\Platform\Bridge\OpenAI;
 
+use Symfony\AI\Platform\Capability;
 use Symfony\AI\Platform\Model;
 
 /**
@@ -27,6 +28,6 @@ class Embeddings extends Model
      */
     public function __construct(string $name = self::TEXT_3_SMALL, array $options = [])
     {
-        parent::__construct($name, [], $options);
+        parent::__construct($name, [Capability::OUTPUT_VECTOR], $options);
     }
 }