bug #847 Skipping missing source directories during copy-from-package unconfiguration (tperunsky)

This PR was submitted for the 2.x branch but it was squashed and merged into the 1.x branch instead.

Discussion
----------

Skipping missing source directories during copy-from-package unconfiguration

#73

This PR makes the output look like this:
![image](https://user-images.githubusercontent.com/2622798/148063629-9f566dd7-f048-4c3e-9cce-e88f4655de74.png)

Commits
-------

776319c Skipping missing source directories during copy-from-package unconfiguration

Author: nicolas-grekas

src/Configurator/CopyFromPackageConfigurator.php

@@ -145,6 +145,9 @@ public function copyFile(string $source, string $target, array $options)
 
     private function removeFilesFromDir(string $source, string $target)
     {
+        if (!is_dir($source)) {
+            return;
+        }
         $iterator = $this->createSourceIterator($source, \RecursiveIteratorIterator::CHILD_FIRST);
         foreach ($iterator as $item) {
             $targetPath = $this->path->concatenate([$target, $iterator->getSubPathName()]);

tests/Configurator/CopyFromPackageConfiguratorTest.php

@@ -110,7 +110,11 @@ public function testUnconfigure()
         file_put_contents($this->targetFile, '');
         $this->assertFileExists($this->targetFile);
         $lock = $this->getMockBuilder(Lock::class)->disableOriginalConstructor()->getMock();
-        $this->createConfigurator()->unconfigure($this->recipe, [$this->sourceFileRelativePath => $this->targetFileRelativePath], $lock);
+        $this->createConfigurator()->unconfigure(
+            $this->recipe,
+            [$this->sourceFileRelativePath => $this->targetFileRelativePath, 'missingdir/' => ''],
+            $lock
+        );
         $this->assertFileDoesNotExist($this->targetFile);
     }