Fix PHPUnit DataProvider

Author: Kocal

tests/AssertionsTest.php

@@ -15,6 +15,7 @@
 
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
 use Symfony\Component\BrowserKit\AbstractBrowser;
+use PHPUnit\Framework\Attributes\DataProvider;
 
 class AssertionsTest extends TestCase
 {
@@ -29,6 +30,7 @@ protected function setUp(): void
         }
     }
 
+    #[DataProvider('clientFactoryProvider')]
     /**
      * @dataProvider clientFactoryProvider
      */

tests/ClientTest.php

@@ -20,6 +20,7 @@
 use Facebook\WebDriver\JavaScriptExecutor;
 use Facebook\WebDriver\WebDriver;
 use Facebook\WebDriver\WebDriverExpectedCondition;
+use PHPUnit\Framework\Attributes\DataProvider;
 use Symfony\Component\BrowserKit\AbstractBrowser;
 use Symfony\Component\BrowserKit\Cookie;
 use Symfony\Component\BrowserKit\CookieJar as BrowserKitCookieJar;
@@ -56,6 +57,8 @@ public function testWaitForEmptyLocator(): void
         $client->waitFor('');
     }
 
+    #[DataProvider('waitForDataProvider')]
+
     /**
      * @dataProvider waitForDataProvider
      */
@@ -83,6 +86,7 @@ public static function waitForDataProvider(): iterable
         yield 'xpath expression' => ['locator' => '//*[@id="hello"]'];
     }
 
+    #[DataProvider('waitForDataProvider')]
     /**
      * @dataProvider waitForDataProvider
      */
@@ -95,6 +99,7 @@ public function testWaitForVisibility(string $locator): void
         $this->assertSame('Hello', $crawler->filter('#hello')->text(null, true));
     }
 
+    #[DataProvider('waitForDataProvider')]
     /**
      * @dataProvider waitForDataProvider
      */
@@ -107,6 +112,7 @@ public function testWaitForInvisibility(string $locator): void
         $this->assertSame('', $crawler->filter('#hello')->text(null, true));
     }
 
+    #[DataProvider('waitForDataProvider')]
     /**
      * @dataProvider waitForDataProvider
      */
@@ -119,6 +125,7 @@ public function testWaitForElementToContain(string $locator): void
         $this->assertSame('Hello new content', $crawler->filter('#hello')->text(null, true));
     }
 
+    #[DataProvider('waitForDataProvider')]
     /**
      * @dataProvider waitForDataProvider
      */
@@ -131,6 +138,7 @@ public function testWaitForElementToNotContain(string $locator): void
         $this->assertSame('Hello', $crawler->filter('#hello')->text(null, true));
     }
 
+    #[DataProvider('waitForDataProvider')]
     /**
      * @dataProvider waitForDataProvider
      */
@@ -143,6 +151,7 @@ public function testWaitForEnabled(string $locator): void
         $this->assertTrue($crawler->filter('#hello')->isEnabled());
     }
 
+    #[DataProvider('waitForDataProvider')]
     /**
      * @dataProvider waitForDataProvider
      */
@@ -155,6 +164,7 @@ public function testWaitForDisabled(string $locator): void
         $this->assertFalse($crawler->filter('#hello')->isEnabled());
     }
 
+    #[DataProvider('waitForDataProvider')]
     /**
      * @dataProvider waitForDataProvider
      */
@@ -167,6 +177,7 @@ public function testWaitForAttributeToContain(string $locator): void
         $this->assertSame('42', $crawler->filter('#hello')->getAttribute('data-old-price'));
     }
 
+    #[DataProvider('waitForDataProvider')]
     /**
      * @dataProvider waitForDataProvider
      */
@@ -179,6 +190,7 @@ public function testWaitForAttributeToNotContain(string $locator): void
         $this->assertSame('36', $crawler->filter('#hello')->getAttribute('data-old-price'));
     }
 
+    #[DataProvider('waitForDataProvider')]
     /**
      * @dataProvider waitForDataProvider
      */
@@ -244,6 +256,7 @@ public static function waitForExceptionsProvider(): iterable
         ];
     }
 
+    #[DataProvider('waitForExceptionsProvider')]
     /**
      * @dataProvider waitForExceptionsProvider
      */
@@ -288,6 +301,7 @@ public function testExecuteAsyncScript(): void
         $this->assertSame('P1', $innerText);
     }
 
+    #[DataProvider('clientFactoryProvider')]
     /**
      * @dataProvider clientFactoryProvider
      */
@@ -319,6 +333,7 @@ public function testRefreshCrawler(): void
         $this->assertSame('Hello', $refreshedCrawler->filter('h1')->text(null, true));
     }
 
+    #[DataProvider('clientFactoryProvider')]
     /**
      * @dataProvider clientFactoryProvider
      */
@@ -337,6 +352,7 @@ public function testFollowLink(callable $clientFactory, string $type): void
         $this->assertSame(self::$baseUri.'/basic.html#e12', $crawler->getUri());
     }
 
+    #[DataProvider('clientFactoryProvider')]
     /**
      * @dataProvider clientFactoryProvider
      */
@@ -392,6 +408,7 @@ public function testSubmitForm(callable $clientFactory): void
         $this->assertSame('I1: n/a', $crawler->filter('#result')->text(null, true));
     }
 
+    #[DataProvider('clientFactoryProvider')]
     /**
      * @dataProvider clientFactoryProvider
      */
@@ -418,6 +435,7 @@ public function testSubmitFormWithValues(callable $clientFactory): void
         $this->assertSame('I1: Reclus', $crawler->filter('#result')->text(null, true));
     }
 
+    #[DataProvider('clientFactoryProvider')]
     /**
      * @dataProvider clientFactoryProvider
      */
@@ -445,6 +463,7 @@ public function testHistory(callable $clientFactory): void
         $this->assertSame(self::$baseUri.'/link.html', $crawler->getUri());
     }
 
+    #[DataProvider('clientFactoryProvider')]
     /**
      * @dataProvider clientFactoryProvider
      */
@@ -497,6 +516,7 @@ public function testCookie(callable $clientFactory, string $type): void
         $this->assertNull($cookieJar->get('foo'));
     }
 
+    #[DataProvider('clientFactoryProvider')]
     /**
      * @dataProvider clientFactoryProvider
      */
@@ -507,6 +527,7 @@ public function testServerPort(callable $clientFactory): void
         $this->assertEquals($expectedPort, mb_substr(self::$baseUri, -4));
     }
 
+    #[DataProvider('clientFactoryProvider')]
     /**
      * @dataProvider clientFactoryProvider
      */
@@ -596,6 +617,7 @@ public function testCreateHttpBrowserClientWithInvalidHttpClientOptions(): void
         ]);
     }
 
+    #[DataProvider('providePrefersReducedMotion')]
     /**
      * @dataProvider providePrefersReducedMotion
      */
@@ -608,6 +630,7 @@ public function testPrefersReducedMotion(string $browser): void
         $this->assertStringEndsWith('#clicked', $client->getCurrentURL());
     }
 
+    #[DataProvider('providePrefersReducedMotion')]
     /**
      * @dataProvider providePrefersReducedMotion
      */