Merge pull request #51 from tailflow/next

Release v1.2.4

Author: alexzarbn

src/Drivers/Standard/ParamsValidator.php

@@ -49,7 +49,7 @@ public function validateFilters(Request $request): void
             'filters.*.type' => ['sometimes', 'in:and,or'],
             'filters.*.field' => ['required_with:filters', 'regex:/^[\w.]+$/', new WhitelistedField($this->filterableBy)],
             'filters.*.operator' => ['required_with:filters', 'in:<,<=,>,>=,=,!=,like,not like,in,not in'],
-            'filters.*.value' => ['required_with:filters', 'nullable']
+            'filters.*.value' => ['present', 'nullable']
         ])->validate();
     }
 

tests/Feature/StandardIndexFilteringOperationsTest.php

@@ -2,6 +2,7 @@
 
 namespace Orion\Tests\Feature;
 
+use Carbon\Carbon;
 use Illuminate\Support\Facades\Gate;
 use Orion\Tests\Fixtures\App\Models\Company;
 use Orion\Tests\Fixtures\App\Models\Post;
@@ -319,4 +320,24 @@ public function getting_a_list_of_resources_filtered_by_relation_field_with_wild
             $this->makePaginator([$matchingTeam], 'teams/search')
         );
     }
+
+    /** @test */
+    public function getting_a_list_of_resources_filtered_by_model_field_using_nullable_value(): void
+    {
+        $matchingPost = factory(Post::class)->create(['publish_at' => null])->fresh();
+        factory(Post::class)->create(['publish_at' =>  Carbon::now()])->fresh();
+
+        Gate::policy(Post::class, GreenPolicy::class);
+
+        $response = $this->post('/api/posts/search', [
+            'filters' => [
+                ['field' => 'publish_at', 'operator' => '=', 'value' => null]
+            ]
+        ]);
+
+        $this->assertResourcesPaginated(
+            $response,
+            $this->makePaginator([$matchingPost], 'posts/search')
+        );
+    }
 }

tests/Fixtures/app/Http/Controllers/PostsController.php

@@ -32,7 +32,7 @@ protected function sortableBy() : array
 
     protected function filterableBy() : array
     {
-        return ['title', 'position', 'user.name'];
+        return ['title', 'position', 'publish_at', 'user.name'];
     }
 
     protected function searchableBy() : array