You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think we could allow leaveFrom and leaveTo be the reverse of enterFrom and enterTo by default. I know I could deduplicate some of the classes from the transition into the className prop, but I like having the transition specific classes separated out from other classes that I'm applying in there. It would be nice if leave defaulted to enter's classes.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I think there is an opportunity to simplify the required props on
Transition.A lot of usages that I have done and seen for
Transitionare pretty basic and can be inverted. For example:I think we could allow
leaveFromandleaveTobe the reverse ofenterFromandenterToby default. I know I could deduplicate some of the classes from the transition into theclassNameprop, but I like having the transition specific classes separated out from other classes that I'm applying in there. It would be nice ifleavedefaulted toenter's classes.So it would result in something like:
This still leaves room for customizing the
leavetransition but makes it simpler to use for basic use-cases.Another example, with my custom
className:could just be
Beta Was this translation helpful? Give feedback.
All reactions