ci: update GitHub Actions workflows (runners, fixes, stability)

Author: vakhov

.github/pull_request_template.md

@@ -0,0 +1,9 @@
+What has been done? Why? What problem is being solved?
+
+I didn't forget about
+
+- [ ] Tests
+- [ ] Changelog
+- [ ] Documentation
+
+Closes #???

.github/workflows/fast_testing.yaml

@@ -19,39 +19,28 @@ jobs:
       matrix:
         tarantool:
           - '1.10'
-          - '2.4'
-          - '2.5'
-          - '2.6'
-          - '2.7'
-          - '2.8'
           - '2.10'
+          - '2.11'
         cartridge-version:
           - ''
-          - '2.7.4'
+          - '2.16.3'
         metrics-version:
           - ''
-          - '0.10.0'
-          - '0.11.0'
-          - '0.13.0'
+          - '1.5.0'
         coveralls: [false]
         include:
-          - tarantool: '2.10'
-            cartridge-version: '2.7.4'
-            metrics-version: '0.13.0'
-            coveralls: true
-          - tarantool: 'debug-master'
+          - tarantool: '2.11'
             cartridge-version: ''
-            metrics-version: '0.13.0'
-            coveralls: false
+            coveralls: true
 
     env:
       TNT_DEBUG_PATH: /home/runner/tnt-debug
 
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
       - name: Install tarantool ${{ matrix.tarantool }}
         if: startsWith(matrix.tarantool, 'debug') != true
-        uses: tarantool/setup-tarantool@v1
+        uses: tarantool/setup-tarantool@v4
         with:
           tarantool-version: ${{ matrix.tarantool }}
 
@@ -74,7 +63,7 @@ jobs:
 
       - name: Clone tarantool ${{ matrix.tarantool }}
         if: startsWith(matrix.tarantool, 'debug') && steps.cache-tnt-debug.outputs.cache-hit != 'true'
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           repository: tarantool/tarantool
           ref: ${{ env.TNT_BRANCH }}
@@ -101,7 +90,7 @@ jobs:
           sudo cp -rvP ${TNT_DEBUG_PATH}/usr/local/* /usr/local/
 
       - name: Clone the module
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Cache rocks
         uses: actions/cache@v3
@@ -120,7 +109,6 @@ jobs:
 
       - name: Install requirements
         run: make deps
-        if: steps.cache-rocks.outputs.cache-hit != 'true'
 
       - name: Install metrics
         if: matrix.metrics-version != ''
@@ -136,7 +124,14 @@ jobs:
 
       - run: make check
 
-      - run: make coverage
+      - name: Run coverage
+        uses: nick-fields/retry@v3
+        with:
+          max_attempts: 3
+          retry_on: error
+          retry_wait_seconds: 10
+          timeout_minutes: 60
+          command: make coverage
 
       - name: Send code coverage to coveralls.io
         run: make coveralls

.github/workflows/packaging.yml

@@ -12,7 +12,7 @@ on:
 jobs:
   # Run not only on tags, otherwise dependent job will skip.
   version-check:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
       - name: Check module version
         # We need this step to run only on push with tag.
@@ -22,25 +22,15 @@ jobs:
           module-name: 'expirationd'
 
   package:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     needs: version-check
 
     strategy:
       fail-fast: false
       matrix:
         platform:
           - { os: 'debian', dist: 'stretch' }
-          - { os: 'debian', dist: 'buster' }
           - { os: 'debian', dist: 'bullseye' }
-          - { os: 'el', dist: '7' }
-          - { os: 'el', dist: '8' }
-          - { os: 'fedora', dist: '30' }
-          - { os: 'fedora', dist: '31' }
-          - { os: 'fedora', dist: '32' }
-          - { os: 'fedora', dist: '33' }
-          - { os: 'fedora', dist: '34' }
-          - { os: 'fedora', dist: '35' }
-          - { os: 'fedora', dist: '36' }
           - { os: 'ubuntu', dist: 'xenial' }
           - { os: 'ubuntu', dist: 'bionic' }
           - { os: 'ubuntu', dist: 'focal' }
@@ -53,15 +43,15 @@ jobs:
 
     steps:
       - name: Clone the module
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         # `actions/checkout` performs shallow clone of repo. To provide
         # proper version of the package to `packpack` we need to have
         # complete repository, otherwise it will be `0.0.1`.
         with:
           fetch-depth: 0
 
       - name: Clone the packpack tool
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           repository: packpack/packpack
           path: packpack

.github/workflows/publish.yml

@@ -9,7 +9,7 @@ jobs:
   version-check:
     # We need this job to run only on push with tag.
     if: ${{ github.event_name == 'push' && startsWith(github.ref, 'refs/tags/') }}
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
       - name: Check module version
         uses: tarantool/actions/check-module-version@master
@@ -18,9 +18,9 @@ jobs:
 
   publish-rockspec-scm-1:
     if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/master' }}
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - uses: tarantool/rocks.tarantool.org/github-action@master
         with:
           auth: ${{ secrets.ROCKS_AUTH }}
@@ -29,9 +29,9 @@ jobs:
   publish-rockspec-tag:
     if: ${{ github.event_name == 'push' && startsWith(github.ref, 'refs/tags/') }}
     needs: version-check
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       # Create a rockspec for the release.
       - run: printf '%s=%s\n' TAG "${GITHUB_REF##*/}" >> "${GITHUB_ENV}"
@@ -62,7 +62,7 @@ jobs:
       # .src.rock instead. See [1] for description of rock types.
       #
       # [1]: https://github.com/luarocks/luarocks/wiki/Types-of-rocks
-      - uses: tarantool/setup-tarantool@v1
+      - uses: tarantool/setup-tarantool@v4
         with:
           tarantool-version: '1.10'
       - run: tt rocks install expirationd-${{ env.TAG }}-1.rockspec
@@ -81,12 +81,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Install Tarantool
-        uses: tarantool/setup-tarantool@v1
+        uses: tarantool/setup-tarantool@v4
         with:
-          tarantool-version: 2.8
+          tarantool-version: 2.11
 
       - name: Clone the module
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Cache rocks
         uses: actions/cache@v3

.github/workflows/reusable_testing.yml

@@ -11,7 +11,7 @@ on:
 
 jobs:
   run_tests:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
       - name: Clone the expirationd module
         uses: actions/checkout@v4
@@ -36,4 +36,12 @@ jobs:
 
       - run: make deps
       - run: echo $PWD/.rocks/bin >> $GITHUB_PATH
-      - run: make test
+
+      - name: Run tests
+        uses: nick-fields/retry@v3
+        with:
+          max_attempts: 3
+          retry_on: error
+          retry_wait_seconds: 10
+          timeout_minutes: 60
+          command: make test

.gitignore

@@ -10,3 +10,5 @@ tags
 doc/apidoc/
 .idea
 *.swp
+.vscode
+sdk

.luacheckrc

@@ -1,8 +1,3 @@
-globals = {
-    "box",
-    "_TARANTOOL",
-}
-
 ignore = {
     -- Unused argument <self>.
     "212/self",
@@ -16,12 +11,9 @@ ignore = {
     "432",
 }
 
-include_files = {
-    '.luacheckrc',
-    '*.rockspec',
-    '**/*.lua',
-}
-
-exclude_files = {
-    '.rocks',
-}
+redefined = false
+globals = {'box', 'utf8', 'checkers', '_TARANTOOL'}
+include_files = {'**/*.lua', '*.luacheckrc', '*.rockspec'}
+exclude_files = {'**/*.rocks/', 'tmp/', 'sdk'}
+max_line_length = 120
+max_comment_line_length = 150

.luacov

@@ -0,0 +1,9 @@
+local ci_node_index = os.getenv("CI_NODE_INDEX") or ""
+
+return {
+    statsfile = "luacov.stats" .. ci_node_index .. ".out",
+    exclude = {
+        ".rocks",
+        "test",
+    }
+}

Makefile

@@ -5,10 +5,31 @@ MAKEFILE_PATH := $(abspath $(lastword $(MAKEFILE_LIST)))
 PROJECT_DIR := $(patsubst %/,%,$(dir $(MAKEFILE_PATH)))
 LUACOV_REPORT := $(PROJECT_DIR)/luacov.report.out
 LUACOV_STATS := $(PROJECT_DIR)/luacov.stats.out
+METRICS ?= $(METRIC_VERSION)
+CARTRIDGE ?= $(CARTRIDGE_VERSION)
 
 SHELL := $(shell which bash) # Required for brace expansion used in a clean target.
 SEED ?= $(shell /bin/bash -c "echo $$RANDOM")
 
+SHELL := /bin/bash
+
+ARCH := $(shell uname -m)
+PLATFORM ?= $(shell uname -s | tr [:upper:] [:lower:])
+ifeq ($(PLATFORM), darwin)
+    PLATFORM := macos
+endif
+
+PWD := $(shell pwd)
+
+TARANTOOL_BUNDLE_PATH ?= enterprise/dev/$(PLATFORM)/$(ARCH)/2.11/tarantool-enterprise-sdk-gc64-2.11.5-0-g74b51db7f-r662.$(PLATFORM).$(ARCH).tar.gz
+
+VERSION_BRANCH := $(shell git branch --show-current)
+VERSION := $(shell git describe --tags --long | cut -d'-' -f1-2)
+ROCK_FILENAME := expirationd-ee-${VERSION}.all.rock
+
+
+S3_ENDPOINT_URL ?= https://hb.bizmrg.com
+
 all: test
 
 # The template (ldoc.tpl) is written using tarantool specific
@@ -25,7 +46,7 @@ luacheck:
 
 .PHONY: test
 test:
-	luatest -v --coverage --shuffle all:${SEED}
+	.rocks/bin/luatest -v --coverage --shuffle all:${SEED}
 
 $(LUACOV_STATS): test
 
@@ -47,5 +68,42 @@ deps:
 	tt rocks make
 
 deps-full: deps
-	tt rocks install cartridge 2.7.4
-	tt rocks install metrics 0.13.0
+	tt rocks install cartridge 2.16.3
+ifneq ($(strip $(METRICS)),)
+	tt rocks install metrics $(METRICS)
+endif
+
+upload-test-logs-for-fstec:
+	aws --endpoint-url "$(S3_ENDPOINT_URL)" s3 cp expirationd-ee-tests.log "s3://packages/sdk-3-fstec/reports/fstec/expirationd-ee-$(VERSION)-tests.log"
+
+.SILENT: sdk
+sdk: ## Download and Install Tarantool SDK
+	echo Download and Install Tarantool SDK on $(ARCH)
+	aws --endpoint-url "$(S3_ENDPOINT_URL)" s3 cp "s3://packages/$(TARANTOOL_BUNDLE_PATH)" ./sdk.tar.gz \
+	&& mkdir -p sdk \
+	&& tar -xzvf ./sdk.tar.gz -C sdk --strip 1 \
+	&& rm -f ./sdk.tar.gz \
+	&& chmod 644 sdk/rocks/*
+
+.rocks: sdk ## Install Rocks
+	source sdk/env.sh \
+	&& tt rocks install vshard 0.1.36 \
+	&& tt rocks install luatest 1.0.1 \
+	&& tt rocks install luacov 0.13.0 \
+	&& tt rocks install luacov-reporters 0.1.0 \
+	&& tt rocks install luacheck 0.26.0
+ifneq ($(strip $(METRICS)),)
+	source sdk/env.sh && tt rocks install metrics $(METRICS)
+endif
+ifneq ($(strip $(CARTRIDGE)),)
+	source sdk/env.sh && tt rocks install cartridge $(CARTRIDGE)
+endif
+
+install-debug-helper:
+	source sdk/env.sh && tt rocks install https://raw.githubusercontent.com/a1div0/lua-debug-helper/main/lua-debug-helper-1.0.2-1.rockspec
+
+.PHONY: bootstrap
+bootstrap: .rocks ## Installs all dependencies
+
+lint:
+	source sdk/env.sh && .rocks/bin/luacheck .

test/integration/lifetime_all_simple_test.lua

@@ -29,7 +29,7 @@ g.before_each(function(cg)
     -- Restarting instance is the easiest way to achieve it.
     -- It takes around 1s to start an instance, which considering small amount
     -- of integration tests is not a problem.
-    cg.router:start{wait_until_ready = true}
+    cg.router:start()
 end)
 
 g.after_each(function(cg)