Skip to content

Commit 7b79f83

Browse files
authored
Replace ncipollo/release-action with softprops/action-gh-release (#5)
ncipollo/release-action was frequently creating draft releases unintentionally, which disrupted the release flow. Switched to softprops/action-gh-release for more reliable and predictable GitHub release creation.
1 parent a3af99b commit 7b79f83

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: "CI"
22
run-name: |
33
${{
4-
(github.event_name == 'pull_request' && format('Test PR "{0}"', github.event.pull_request.title)) ||
4+
(github.event_name == 'pull_request' && format('Test PR #{0}', github.event.pull_request.number)) ||
55
(github.ref_name == github.event.repository.default_branch && 'Release') ||
66
format('Test branch "{0}"', github.ref_name)
77
}}

.github/workflows/release.yml

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,11 @@ jobs:
2323
- name: "Extract release notes for ${{ inputs.release_name }}"
2424
env:
2525
RELEASE_NAME: "${{ inputs.release_name }}"
26-
run: 'awk "/^## .*$RELEASE_NAME/ { flag=1; next } /^## / { flag=0 } flag" CHANGELOG.md > release-notes.txt'
26+
run: |
27+
awk "/^## .*$RELEASE_NAME/ { flag=1; next } /^## / { flag=0 } flag" CHANGELOG.md > release-notes.txt
28+
if [ -z "$(grep -vE '^$' release-notes.txt || echo)" ]; then
29+
echo "No changes since last release" > release-notes.txt
30+
fi
2731
2832
- name: "Remove old version of release"
2933
if: "${{ inputs.release_name == 'latest' }}"
@@ -33,13 +37,10 @@ jobs:
3337
github_token: "${{ secrets.GITHUB_TOKEN }}"
3438

3539
- name: "Create release"
36-
uses: "ncipollo/release-action@v1"
40+
uses: "softprops/action-gh-release@v2"
3741
with:
38-
tag: "${{ inputs.release_name }}"
39-
bodyFile: "release-notes.txt"
40-
artifacts: "build/out/sdvg-*"
41-
draft: false
42-
prerelease: false
43-
makeLatest: "${{ inputs.release_name == 'latest' }}"
44-
env:
45-
GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
42+
tag_name: "${{ inputs.release_name }}"
43+
body_path: "release-notes.txt"
44+
files: "build/out/sdvg-*"
45+
prerelease: "${{ inputs.release_name == 'latest' }}"
46+
make_latest: "${{ inputs.release_name != 'latest' }}"

0 commit comments

Comments
 (0)