Skip to content
This repository was archived by the owner on Dec 4, 2022. It is now read-only.

Commit 9ddeb61

Browse files
committed
- restore old behavior of requiring package installation
1 parent 024febd commit 9ddeb61

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

src/dependency-builder/build-tree.js

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,8 @@ function findPackagesInPackageJson(packageJson: Object, packagesNames: string[])
221221
* @returns new object with grouped missing
222222
*/
223223
function groupMissing(missing, cwd, consumerPath, bindingPrefix) {
224-
const packageJson = PackageJson.findPackage(cwd);
224+
// temporarily disable this functionality since it cause few bugs: explanation below (on using the packageJson)
225+
// const packageJson = PackageJson.findPackage(cwd);
225226

226227
/**
227228
* Group missing dependencies by types (files, bits, packages)
@@ -252,11 +253,14 @@ function groupMissing(missing, cwd, consumerPath, bindingPrefix) {
252253
});
253254
groups.packages = missingPackages;
254255

255-
if (packageJson) {
256-
const result = findPackagesInPackageJson(packageJson, missingPackages);
257-
groups.packages = result.missingPackages;
258-
Object.assign(foundPackages, result.foundPackages)
259-
}
256+
// temporarily disable this functionality since it cause this bugs:
257+
// https://github.com/teambit/bit/issues/635
258+
// https://github.com/teambit/bit/issues/690
259+
// if (packageJson) {
260+
// const result = findPackagesInPackageJson(packageJson, missingPackages);
261+
// groups.packages = result.missingPackages;
262+
// Object.assign(foundPackages, result.foundPackages)
263+
// }
260264

261265
return { groups, foundPackages };
262266
}

0 commit comments

Comments
 (0)