bug fix - components that require dependencies with custom binding prefix were not recognized

Author: David First

CHANGELOG.md

@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [unreleased]
 
+
+## [0.10.7-dev.6] - 2017-11-22
+
+- bug fix - components that require dependencies with custom binding prefix were not recognized 
+
 ## [0.10.7-dev.3] - 2017-11-17
 
 - improve stability and performance of resolving dependencies
@@ -17,7 +22,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [0.10.7-dev.1] - 2017-11-13
 
-- stylable support
+- Stylable support
 
 ## [0.10.6] - 2017-11-12
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "bit-javascript",
-  "version": "0.10.7-dev.5",
+  "version": "0.10.7-dev.6",
   "scripts": {
     "flow": "flow; test $? -eq 0 -o $? -eq 2",
     "lint": "eslint src && flow check || true",

src/dependency-builder/build-tree.js

@@ -186,17 +186,6 @@ function groupDependencyTree(tree, cwd, bindingPrefix) {
   return result;
 }
 
-/**
- * Group missing dependencies by types (files, bits, packages)
- * @param {Array} missing list of missing paths to group
- * @returns {Function} function which group the dependencies
- */
-const byPathType = R.groupBy((missing) => {
-  return missing.startsWith('bit/') ? 'bits' :
-         missing.startsWith('.') ? 'files' :
-         'packages';
-});
-
 /**
  * Get an import statement path to node package and return the package name
  *
@@ -244,10 +233,23 @@ function resolveModulePath(nmPath, workingDir, root) {
  * to object with missing types
  *
  * @param {Array} missing
+ * @param {string} cwd
+ * @param {string} consumerPath
+ * @param {string} bindingPrefix
  * @returns new object with grouped missing
  */
-function groupMissing(missing, cwd, consumerPath) {
-  const groups = byPathType(missing);
+function groupMissing(missing, cwd, consumerPath, bindingPrefix) {
+  /**
+   * Group missing dependencies by types (files, bits, packages)
+   * @param {Array} missing list of missing paths to group
+   * @returns {Function} function which group the dependencies
+   */
+  const byPathType = R.groupBy((missing) => {
+    return missing.startsWith(`${bindingPrefix}/`) ? 'bits' :
+      missing.startsWith('.') ? 'files' :
+        'packages';
+  });
+  const groups = byPathType(missing, bindingPrefix);
   const packages = groups.packages ? groups.packages.map(resolvePackageNameByPath) : [];
   // This is a hack to solve problems that madge has with packages for type script files
   // It see them as missing even if they are exists
@@ -370,7 +372,7 @@ export default async function getDependencyTree(baseDir: string, consumerPath: s
   Promise<{ missing: Object, tree: Tree}> {
   const config = { baseDir, includeNpm: true, requireConfig: null, webpackConfig: null, visited: {}, nonExistent: [] };
   const result = generateTree(filePaths, config);
-  const { groups, foundPackages } = groupMissing(result.skipped, baseDir, consumerPath);
+  const { groups, foundPackages } = groupMissing(result.skipped, baseDir, consumerPath, bindingPrefix);
   const tree: Tree = groupDependencyTree(result.tree, baseDir, bindingPrefix);
   const relativeFilePaths = filePaths.map(filePath => path.relative(baseDir, filePath));
   // Merge manually found packages with madge founded packages