Skip to content

Commit 9ab9723

Browse files
committed
refactor: remove redundant SonarQube job steps from workflow
1 parent 1b701e6 commit 9ab9723

File tree

1 file changed

+3
-21
lines changed

1 file changed

+3
-21
lines changed

.github/workflows/test.yml

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ on:
1010
types: [opened, synchronize, reopened]
1111

1212
jobs:
13-
typescript-tests:
13+
Tests:
1414
runs-on: ubuntu-latest
1515
name: TypeScript Tests
1616
permissions:
@@ -35,27 +35,9 @@ jobs:
3535
env:
3636
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3737

38-
sonarqube-scan:
39-
runs-on: ubuntu-latest
40-
name: SonarQube Analysis
41-
permissions:
42-
contents: read
43-
steps:
44-
- uses: actions/checkout@v4
45-
with:
46-
# Disabling shallow clone is recommended for improving relevancy of reporting
47-
fetch-depth: 0
48-
49-
- name: Setup Node.js
50-
uses: actions/setup-node@v4
51-
with:
52-
node-version-file: .node-version
53-
cache: npm
54-
55-
- name: Install Dependencies
56-
run: npm ci --no-fund
57-
38+
# Note: SonarQube requires the results from tests to get the coverage report
5839
- name: SonarQube Scan
5940
uses: SonarSource/sonarqube-scan-action@2500896589ef8f7247069a56136f8dc177c27ccf # v5
6041
env:
6142
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
43+

0 commit comments

Comments
 (0)