Skip to content

Commit 9a9cbe7

Browse files
committed
improve some test flakiness for envconfig module tests
1 parent 6d46912 commit 9a9cbe7

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

core-api/src/envconfig.rs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1129,7 +1129,7 @@ namespace = "my-namespace"
11291129
..Default::default()
11301130
};
11311131

1132-
let profile = load_client_config_profile(options, None).unwrap();
1132+
let profile = load_client_config_profile(options, Some(&HashMap::new())).unwrap();
11331133
assert_eq!(profile.address.as_ref().unwrap(), "my-address");
11341134
assert_eq!(profile.namespace.as_ref().unwrap(), "my-namespace");
11351135
}
@@ -1519,7 +1519,7 @@ address = "localhost:7233"
15191519
};
15201520

15211521
// Should not error, just returns an empty profile
1522-
let profile = load_client_config_profile(options, None).unwrap();
1522+
let profile = load_client_config_profile(options, Some(&HashMap::new())).unwrap();
15231523
assert_eq!(profile, ClientConfigProfile::default());
15241524
}
15251525

@@ -1595,7 +1595,7 @@ api_key = "my-api-key"
15951595
..Default::default()
15961596
};
15971597

1598-
let profile = load_client_config_profile(options, None).unwrap();
1598+
let profile = load_client_config_profile(options, Some(&HashMap::new())).unwrap();
15991599

16001600
// TLS should be enabled due to API key presence
16011601
assert!(profile.tls.is_some());
@@ -1616,14 +1616,17 @@ address = "some-address"
16161616
..Default::default()
16171617
};
16181618

1619-
let profile = load_client_config_profile(options, None).unwrap();
1619+
let profile = load_client_config_profile(options, Some(&HashMap::new())).unwrap();
16201620

16211621
// TLS should not be enabled
16221622
assert!(profile.tls.is_none());
16231623
}
16241624

16251625
#[test]
16261626
fn test_load_client_config_profile_from_system_env() {
1627+
// WARNING: This test modifies system environment variables which can cause
1628+
// test pollution if tests run in parallel.
1629+
16271630
// Set up system env vars. These tests can't be run in parallel.
16281631
unsafe {
16291632
std::env::set_var("TEMPORAL_ADDRESS", "system-address");

0 commit comments

Comments
 (0)