Treat UpdateWorkflowExecution as a long poll (#1784)

Author: Quinn-With-Two-Ns

temporal-sdk/src/main/java/io/temporal/internal/client/RootWorkflowClientInvoker.java

@@ -49,6 +49,7 @@
 
 public class RootWorkflowClientInvoker implements WorkflowClientCallsInterceptor {
   private static final Logger log = LoggerFactory.getLogger(RootWorkflowClientInvoker.class);
+  private static final long POLL_UPDATE_TIMEOUT_S = 60L;
 
   private final GenericWorkflowClient genericClient;
   private final WorkflowClientOptions clientOptions;
@@ -324,7 +325,9 @@ public <R> StartUpdateOutput<R> startUpdate(StartUpdateInput<R> input) {
             .setFirstExecutionRunId(input.getFirstExecutionRunId())
             .setRequest(request)
             .build();
-    UpdateWorkflowExecutionResponse result = genericClient.update(updateRequest);
+    Deadline pollTimeoutDeadline = Deadline.after(POLL_UPDATE_TIMEOUT_S, TimeUnit.SECONDS);
+    UpdateWorkflowExecutionResponse result =
+        genericClient.update(updateRequest, pollTimeoutDeadline);
 
     if (result.hasOutcome()) {
       switch (result.getOutcome().getValueCase()) {
@@ -424,7 +427,8 @@ private void pollWorkflowUpdateHelper(
       PollWorkflowExecutionUpdateRequest request,
       Deadline deadline) {
 
-    Deadline pollTimeoutDeadline = Deadline.after(60L, TimeUnit.SECONDS).minimum(deadline);
+    Deadline pollTimeoutDeadline =
+        Deadline.after(POLL_UPDATE_TIMEOUT_S, TimeUnit.SECONDS).minimum(deadline);
     genericClient
         .pollUpdateAsync(request, pollTimeoutDeadline)
         .whenComplete(

temporal-sdk/src/main/java/io/temporal/internal/client/external/GenericWorkflowClient.java

@@ -40,7 +40,8 @@ SignalWithStartWorkflowExecutionResponse signalWithStart(
   QueryWorkflowResponse query(QueryWorkflowRequest queryParameters);
 
   @Experimental
-  UpdateWorkflowExecutionResponse update(UpdateWorkflowExecutionRequest updateParameters);
+  UpdateWorkflowExecutionResponse update(
+      @Nonnull UpdateWorkflowExecutionRequest updateParameters, @Nonnull Deadline deadline);
 
   @Experimental
   CompletableFuture<PollWorkflowExecutionUpdateResponse> pollUpdateAsync(

temporal-sdk/src/main/java/io/temporal/internal/client/external/GenericWorkflowClientImpl.java

@@ -318,7 +318,8 @@ private static <T> CompletableFuture<T> toCompletableFuture(
   }
 
   @Override
-  public UpdateWorkflowExecutionResponse update(UpdateWorkflowExecutionRequest updateParameters) {
+  public UpdateWorkflowExecutionResponse update(
+      @Nonnull UpdateWorkflowExecutionRequest updateParameters, @Nonnull Deadline deadline) {
     Map<String, String> tags =
         new ImmutableMap.Builder<String, String>(1)
             .put(MetricsTag.UPDATE_NAME, updateParameters.getRequest().getInput().getName())
@@ -329,9 +330,10 @@ public UpdateWorkflowExecutionResponse update(UpdateWorkflowExecutionRequest upd
         () ->
             service
                 .blockingStub()
+                .withDeadline(deadline)
                 .withOption(METRICS_TAGS_CALL_OPTIONS_KEY, scope)
                 .updateWorkflowExecution(updateParameters),
-        grpcRetryerOptions);
+        new GrpcRetryer.GrpcRetryerOptions(DefaultStubLongPollRpcRetryOptions.INSTANCE, deadline));
   }
 
   @Override

temporal-serviceclient/src/main/java/io/temporal/serviceclient/LongPollUtil.java

@@ -30,6 +30,7 @@ static <ReqT, RespT> boolean isLongPoll(
       MethodDescriptor<ReqT, RespT> method, CallOptions callOptions) {
     if (method == WorkflowServiceGrpc.getPollWorkflowTaskQueueMethod()
         || method == WorkflowServiceGrpc.getPollActivityTaskQueueMethod()
+        || method == WorkflowServiceGrpc.getUpdateWorkflowExecutionMethod()
         || method == WorkflowServiceGrpc.getPollWorkflowExecutionUpdateMethod()) {
       return true;
     }