Cloud automation for Enterprise Application Service content review #112
Conversation
ibm_catalog.json
Outdated
| "title": "Supports building, deploying and running Jakarta EE/MicroProfile applications on Liberty in public cloud", | ||
| "description": "Supports building, deploying and running Jakarta EE/MicroProfile applications on Liberty in public cloud.<br/>For more details about the features and the options available please refer to this [page](https://github.com/terraform-ibm-modules/terraform-ibm-enterprise-app-java/blob/main/solutions/fully-configurable/DA-details.md)." | ||
| "title": "Creates an Enterprise Application Service instance", | ||
| "description": "Get started with Enterprise Application Service by creating an instance. [Learn more](https://github.com/terraform-ibm-modules/terraform-ibm-enterprise-app-java/blob/main/solutions/fully-configurable/DA-details.md)." |
There was a problem hiding this comment.
I took the description from the Enterprise application service description, I think it provides a better idea to the user of what is going to deploy
variables.tf
Outdated
| validation { | ||
| condition = var.repos_git_token != null ? (var.source_repo != null && var.config_repo != null) : (var.source_repo == null && var.config_repo == null) | ||
| error_message = "If at least one of var.source_repo, var.config_repo, var.repos_git_token input parameters is not null all of them must be assigned with a value, but var.repos_git_token is null." | ||
| error_message = "`var.repos_git_token` cannot be set to `null` if `var.source_repo` and `var.config_repo` are not also set to `null`." |
There was a problem hiding this comment.
Still not fully clear (also the original one probably): we need to underline that these parameters must be all set to null or all set to a value != null (this means that if any of them is != null, also the other ones mut be != null)
There was a problem hiding this comment.
Would we also throw this error if var.repos_git_token is set to a value but one or both of the other variables are set to null ?
|
/run pipeline |
|
@maheshwarishikha adding you as reviewer, I contributed on catalog content |
|
tests to be fixed through #114 (rebase once merged that) |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
@knee-na ^^ |
|
/run pipeline |
3 participants
Description
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers