Skip to content

Commit 7e3aea6

Browse files
committed
Cover a caller-supplied /dev/shm bind in the reuse test
1 parent 777caaa commit 7e3aea6

2 files changed

Lines changed: 29 additions & 0 deletions

File tree

modules/selenium/src/test/java/org/testcontainers/containers/BrowserWebDriverContainerReuseTest.java

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,18 @@ void configureDoesNotAddDuplicateShmBindOnReuse() {
3131

3232
assertThat(shmBinds).isEqualTo(1);
3333
}
34+
35+
@Test
36+
@DisabledOnOs(OS.WINDOWS)
37+
void configureKeepsACallerSuppliedShmBind() {
38+
BrowserWebDriverContainer<?> container = new BrowserWebDriverContainer<>(CHROME_IMAGE);
39+
container.withFileSystemBind("/tmp/shm", "/dev/shm", BindMode.READ_ONLY);
40+
41+
container.configure();
42+
43+
assertThat(container.getBinds())
44+
.filteredOn(bind -> "/dev/shm".equals(bind.getVolume().getPath()))
45+
.singleElement()
46+
.satisfies(bind -> assertThat(bind.getPath()).isEqualTo("/tmp/shm"));
47+
}
3448
}

modules/selenium/src/test/java/org/testcontainers/selenium/BrowserWebDriverContainerReuseTest.java

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import org.junit.jupiter.api.Test;
55
import org.junit.jupiter.api.condition.DisabledOnOs;
66
import org.junit.jupiter.api.condition.OS;
7+
import org.testcontainers.containers.BindMode;
78
import org.testcontainers.utility.DockerImageName;
89

910
import static org.assertj.core.api.Assertions.assertThat;
@@ -31,4 +32,18 @@ void configureDoesNotAddDuplicateShmBindOnReuse() {
3132

3233
assertThat(shmBinds).isEqualTo(1);
3334
}
35+
36+
@Test
37+
@DisabledOnOs(OS.WINDOWS)
38+
void configureKeepsACallerSuppliedShmBind() {
39+
BrowserWebDriverContainer container = new BrowserWebDriverContainer(CHROME_IMAGE);
40+
container.withFileSystemBind("/tmp/shm", "/dev/shm", BindMode.READ_ONLY);
41+
42+
container.configure();
43+
44+
assertThat(container.getBinds())
45+
.filteredOn(bind -> "/dev/shm".equals(bind.getVolume().getPath()))
46+
.singleElement()
47+
.satisfies(bind -> assertThat(bind.getPath()).isEqualTo("/tmp/shm"));
48+
}
3449
}

0 commit comments

Comments
 (0)