Skip to content

Commit 9206e8d

Browse files
committed
Update image var on CustomContainer
1 parent 27dfc5a commit 9206e8d

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

core/testcontainers/core/generic.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@ class CustomContainer(DockerContainer):
9494
"""
9595

9696
def __init__(self, tag: str, path: str) -> None:
97-
self.image_obj = DockerImage(tag, path).build()
98-
super().__init__(self.image_obj.tag)
97+
self.docker_image = DockerImage(tag, path).build()
98+
super().__init__(self.docker_image.tag)
9999

100100
def get_url(self) -> str:
101101
raise NotImplementedError
@@ -106,4 +106,4 @@ def start(self) -> "CustomContainer":
106106

107107
def stop(self, force=True, delete_volume=True) -> None:
108108
super().stop(force, delete_volume)
109-
self.image_obj.remove()
109+
self.docker_image.remove()

core/tests/test_core.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,6 @@ def test_custom_container():
6868
)
6969
f.close()
7070
with CustomContainer(tag="custom-image:test", path=temp_directory) as server:
71-
image_build_logs = server.image_obj.get_logs()
72-
assert isinstance(image_build_logs, list)
73-
assert image_build_logs[0] == {"stream": "Step 1/2 : FROM alpine:latest"}
71+
image_build_logs = server.docker_image.get_logs()
7472
assert image_build_logs[3] == {"stream": 'Step 2/2 : CMD echo "This is a custom Docker Image!"'}
7573
wait_for_logs(server, "This is a custom Docker Image!")

0 commit comments

Comments
 (0)