Address review feedback: Remove re-exports, enable mixed usage with warnings, remove v20 references

Co-authored-by: timdeschryver <[email protected]>

Author: Copilot

README.md

@@ -151,12 +151,13 @@ describe('Counter', () => {
 });
 ```
 
-### Angular v20+ Bindings API
+### Angular Bindings API
 
-Angular Testing Library also supports Angular v20's native bindings API, which provides a more direct way to bind inputs and outputs:
+Angular Testing Library also supports Angular's native bindings API, which provides a more direct way to bind inputs and outputs:
 
 ```typescript
-import { render, screen, inputBinding, outputBinding } from '@testing-library/angular';
+import { render, screen } from '@testing-library/angular';
+import { inputBinding, outputBinding } from '@angular/core';
 import { CounterComponent } from './counter.component';
 
 describe('Counter with Bindings API', () => {

projects/testing-library/src/lib/models.ts

@@ -310,7 +310,7 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo
 
   /**
    * @description
-   * An array of bindings to apply to the component using Angular v20+'s native bindings API.
+   * An array of bindings to apply to the component using Angular's native bindings API.
    * This provides a more direct way to bind inputs and outputs compared to the `inputs` and `on` options.
    *
    * @default

projects/testing-library/src/lib/testing-library.ts

@@ -196,16 +196,35 @@ export async function render<SutType, WrapperType = SutType>(
   ): Promise<ComponentFixture<SutType>> => {
     const createdFixture: ComponentFixture<SutType> = await createComponent(componentContainer, bindings);
 
-    // Only use traditional input/output setting if no bindings are provided
-    // When bindings are used, they handle inputs and outputs natively
-    if (!bindings || bindings.length === 0) {
-      setComponentProperties(createdFixture, properties);
-      setComponentInputs(createdFixture, inputs);
+    // Always apply componentProperties (non-input properties)
+    setComponentProperties(createdFixture, properties);
+
+    // Angular doesn't allow mixing setInput with bindings
+    // So we use bindings OR traditional approach, but not both for inputs
+    if (bindings && bindings.length > 0) {
+      // When bindings are used, warn if traditional inputs/outputs are also specified
+      if (Object.keys(inputs).length > 0) {
+        console.warn(
+          'ATL: You specified both bindings and traditional inputs. ' +
+            'Angular does not allow mixing setInput() with inputBinding(). ' +
+            'Only bindings will be used for inputs. Use bindings for all inputs to avoid this warning.',
+        );
+      }
+      if (Object.keys(subscribeTo).length > 0) {
+        console.warn(
+          'ATL: You specified both bindings and traditional output listeners. ' +
+            'Consider using outputBinding() for all outputs for consistency.',
+        );
+      }
+
+      // Only apply traditional outputs, as bindings handle inputs
       setComponentOutputs(createdFixture, outputs);
       subscribedOutputs = subscribeToComponentOutputs(createdFixture, subscribeTo);
     } else {
-      // With bindings, we still need to handle componentProperties for non-input properties
-      setComponentProperties(createdFixture, properties);
+      // Use traditional approach when no bindings
+      setComponentInputs(createdFixture, inputs);
+      setComponentOutputs(createdFixture, outputs);
+      subscribedOutputs = subscribeToComponentOutputs(createdFixture, subscribeTo);
     }
 
     if (removeAngularAttributes) {

projects/testing-library/src/public_api.ts

@@ -5,6 +5,3 @@
 export * from './lib/models';
 export * from './lib/config';
 export * from './lib/testing-library';
-
-// Re-export Angular's binding functions for convenience
-export { inputBinding, outputBinding, twoWayBinding, type Binding } from '@angular/core';

projects/testing-library/tests/bindings-support.spec.ts

@@ -1,5 +1,5 @@
-import { Component, input, output } from '@angular/core';
-import { render, screen, inputBinding, outputBinding } from '../src/public_api';
+import { Component, input, output, inputBinding, outputBinding } from '@angular/core';
+import { render, screen, aliasedInput } from '../src/public_api';
 
 describe('ATL Bindings API Support', () => {
   @Component({
@@ -38,4 +38,45 @@ describe('ATL Bindings API Support', () => {
 
     expect(clickHandler).toHaveBeenCalledWith('clicked: bound-value');
   });
+
+  it('should warn when mixing bindings with traditional inputs but still work', async () => {
+    const consoleSpy = jest.spyOn(console, 'warn').mockImplementation();
+    const clickHandler = jest.fn();
+    const bindingClickHandler = jest.fn();
+
+    await render(BindingsTestComponent, {
+      bindings: [inputBinding('value', () => 'binding-value'), outputBinding('clicked', bindingClickHandler)],
+      inputs: {
+        ...aliasedInput('greet', 'traditional-greeting'), // This will be ignored due to bindings
+      },
+      on: {
+        clicked: clickHandler, // This should still work alongside bindings
+      },
+    });
+
+    // Only binding should work for inputs
+    expect(screen.getByTestId('value')).toHaveTextContent('binding-value');
+    expect(screen.getByTestId('greeting')).toHaveTextContent('hello'); // Default value, not traditional
+
+    const button = screen.getByTestId('emit-button');
+    button.click();
+
+    // Both binding and traditional handlers should be called for outputs
+    expect(bindingClickHandler).toHaveBeenCalledWith('clicked: binding-value');
+    expect(clickHandler).toHaveBeenCalledWith('clicked: binding-value');
+
+    // Should show warning about mixed usage for inputs
+    expect(consoleSpy).toHaveBeenCalledWith(
+      'ATL: You specified both bindings and traditional inputs. ' +
+        'Angular does not allow mixing setInput() with inputBinding(). ' +
+        'Only bindings will be used for inputs. Use bindings for all inputs to avoid this warning.',
+    );
+
+    expect(consoleSpy).toHaveBeenCalledWith(
+      'ATL: You specified both bindings and traditional output listeners. ' +
+        'Consider using outputBinding() for all outputs for consistency.',
+    );
+
+    consoleSpy.mockRestore();
+  });
 });