Extract recommended config generation for testing

Author: nickserv

lib/index.js

@@ -17,13 +17,17 @@ let requireIndex = require('requireindex');
 // import all rules in lib/rules
 module.exports.rules = requireIndex(__dirname + '/rules');
 
+module.exports.generateRecommendedConfig = rules => {
+  return Object.entries(rules).reduce(
+    (memo, [name, rule]) =>
+      rule.meta.docs.recommended ? { ...memo, [name]: 'error' } : memo,
+    {}
+  );
+};
+
 module.exports.configs = {
   recommended: {
     plugins: ['jest-dom'],
-    rules: Object.entries(module.exports.rules).reduce(
-      (memo, [name, rule]) =>
-        rule.meta.docs.recommended ? { ...memo, [name]: 'error' } : memo,
-      {}
-    ),
+    rules: module.exports.generateRecommendedConfig(module.exports.rules),
   },
 };

tests/index.test.js

@@ -1,15 +1,14 @@
-const { rules, configs } = require('../lib/index');
+const { rules, generateRecommendedConfig, configs } = require('../lib/index');
 
 it('should have all the rules', () => {
   expect(rules).toMatchSnapshot();
 });
 
 it('should have a recommended config with recommended rules', () => {
-  for (const [name, rule] of Object.entries(rules)) {
-    if (rule.meta.docs.recommended) {
-      expect(configs.recommended.rules).toHaveProperty(name, 'error');
-    } else {
-      expect(configs.recommended.rules).not.toHaveProperty(name);
-    }
-  }
+  expect(
+    generateRecommendedConfig({
+      good: { meta: { docs: { recommended: true } } },
+      bad: { meta: { docs: { recommended: false } } },
+    })
+  ).toEqual({ good: 'error' });
 });