From dde9ec829ffd9319e12e1a1f532673a80aa2ced9 Mon Sep 17 00:00:00 2001 From: Chetas Murali Date: Wed, 10 Sep 2025 11:13:43 +0530 Subject: [PATCH 1/2] Fix PR workflow --- .github/workflows/approval-worker.yml | 51 +++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 .github/workflows/approval-worker.yml diff --git a/.github/workflows/approval-worker.yml b/.github/workflows/approval-worker.yml new file mode 100644 index 00000000000..2082636bd93 --- /dev/null +++ b/.github/workflows/approval-worker.yml @@ -0,0 +1,51 @@ +name: Approval Check Worker + +on: + issue_comment: + types: [created] + +jobs: + run-when-command: + if: > + github.event.issue.pull_request != null && + (contains(github.event.comment.body, '/review') || contains(github.event.comment.body, 'review')) + runs-on: ubuntu-latest + permissions: + contents: read + pull-requests: write + issues: write + statuses: write + + outputs: + number: ${{ steps.pr.outputs.number }} + sha: ${{ steps.pr.outputs.sha }} + + steps: + - name: Get latest PR head SHA + id: pr + uses: actions/github-script@v7 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + script: | + const prNumber = context.payload.issue.number; + const { data: pr } = await github.rest.pulls.get({ + owner: context.repo.owner, + repo: context.repo.repo, + pull_number: prNumber, + }); + core.setOutput('number', String(prNumber)); + core.setOutput('sha', pr.head.sha); + + check-approvals: + needs: run-when-command + if: ${{ always() && needs.run-when-command.result == 'success' }} + permissions: + contents: write + pull-requests: write + statuses: write + issues: write + uses: tetherto/qvac-devops/.github/workflows/approval-check-worker.yml@temp-pr-workflow-new + secrets: inherit + with: + pr_number: ${{ fromJSON(needs.run-when-command.outputs.number) }} + pr_sha: ${{ needs.run-when-command.outputs.sha }} From 0988fe8439f9a79ef485d235b7d86ccb27b2bfe6 Mon Sep 17 00:00:00 2001 From: kapildev421 Date: Mon, 22 Sep 2025 19:03:28 +0530 Subject: [PATCH 2/2] Update approval-worker.yml --- .github/workflows/approval-worker.yml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/approval-worker.yml b/.github/workflows/approval-worker.yml index 2082636bd93..c7f973929f1 100644 --- a/.github/workflows/approval-worker.yml +++ b/.github/workflows/approval-worker.yml @@ -3,12 +3,10 @@ name: Approval Check Worker on: issue_comment: types: [created] - + jobs: run-when-command: - if: > - github.event.issue.pull_request != null && - (contains(github.event.comment.body, '/review') || contains(github.event.comment.body, 'review')) + if: "github.event.issue.pull_request != null && (contains(github.event.comment.body, '/review') || contains(github.event.comment.body, 'review'))" runs-on: ubuntu-latest permissions: contents: read @@ -44,8 +42,9 @@ jobs: pull-requests: write statuses: write issues: write - uses: tetherto/qvac-devops/.github/workflows/approval-check-worker.yml@temp-pr-workflow-new + uses: tetherto/qvac-devops/.github/workflows/approval-check-worker.yml@production-workflows-tag secrets: inherit with: pr_number: ${{ fromJSON(needs.run-when-command.outputs.number) }} pr_sha: ${{ needs.run-when-command.outputs.sha }} +