Release/1.1 (#240)

* fix typos in messages

* Squashed commit of the following:

commit 80e7206
Author: George Roberts <[email protected]>
Date:   Mon Feb 8 10:51:21 2021 -0600

    Remove test log line

commit bf4d89d
Author: George Roberts <[email protected]>
Date:   Sat Feb 6 23:26:55 2021 -0600

    Remove some extraneous logging

commit db994e3
Author: George Roberts <[email protected]>
Date:   Sat Feb 6 23:16:06 2021 -0600

    Fix tests

commit c5945cd
Author: George Roberts <[email protected]>
Date:   Sat Feb 6 22:57:14 2021 -0600

    Fix bypassrules value

commit 59f338d
Author: George Roberts <[email protected]>
Date:   Sat Feb 6 22:54:45 2021 -0600

    Support for .bypassrules directive

* fixed an issue which caused removing work item links to fail

* Fix ".check revision false" directive disappearing on rule upload

* change log

* Add tests to check more double assignment cases

* Fixes #229 - double assignment and reset to original value

Alternative implementation to PR #236

* Fixes spurious upgrade message noted in #225

* trigger build

* Fully async

Co-authored-by: Rob Osborne <[email protected]>
Co-authored-by: Alexander Omelchuk <[email protected]>

Author: 3 people

Next-Release-ChangeLog.md

@@ -3,34 +3,29 @@ This release fixes a number of issues and introduce an additional CLI command.
 
 CLI Commands and Options
 ========================
-- Removed annoying messages about new version check.
-- Deprecation warning on missing `--resourceGroup` option.
-- Changed `IDataProtectionProvider.CreateProtector` purpose string to prevent clashes.
-- New `update.mappings` command.
+- Fixes spurious upgrade message noted in #225.
 
 
 Docker and Azure Function Hosting
 ========================
-- Retry after Http 429 using Polly, address #71.
-- Harden Azure resources (see #225).
+No changes.
 
 
 Rule Language
 ========================
-No changes.
+- Added support for `.bypassrules` directive (#83, #228).
+- Fixes #231 (Directive check revision false missing after `update.rule`).
 
 
 Rule Interpreter Engine
 ========================
-- Address #185 by removing field when set to null value.
-- Impersonation does not work when a rule updates the same work item bug (#206).
+- Fixes #229 (Updating a work item field with impersonation enabled fails with the message: _Remove requires Value to be null_).
+- Fixes #234 (_Object reference not set_ when removing a work item link).
 
 
 Build, Test, Documentation
 ========================
-- Terraform and PowerShell scripts to setup a dev VM.
-- Use latest GitVersion.
-- Drop log streaming in favour of reading the application log file: integration tests should become more reliable.
+- SonarCloud now requires Java 11.
 
 
 File Hashes

src/.build-trigger

@@ -1 +0,0 @@
-.

src/aggregator-cli/Instances/FunctionRuntimePackage.cs

@@ -57,8 +57,8 @@ internal FunctionRuntimePackage(ILogger logger)
             logger.WriteVerbose($"Found {gitHubVersion.Name} on {gitHubVersion.When} in GitHub.");
 
             SemVersion.TryParse(gitHubVersion.Name.Substring(1), out var latest);
-            var current = new SemVersion(
-                Assembly.GetEntryAssembly().GetName().Version);
+            var asmVer = Assembly.GetEntryAssembly().GetName().Version;
+            var current = new SemVersion(asmVer.Major, asmVer.Minor, asmVer.Build);
 
             bool upgrade = latest.CompareTo(current) > 0;
             return upgrade

src/aggregator-cli/Mappings/UpdateMappingsCommand.cs

@@ -5,13 +5,13 @@
 namespace aggregator.cli
 {
 
-    [Verb("update.mappings", HelpText = "Updates existing mappings from old to new Aggrergator Instance.")]
+    [Verb("update.mappings", HelpText = "Updates existing mappings from old to new Aggregator Instance.")]
     class UpdateMappingsCommand : CommandBase
     {
         [Option('s', "sourceInstance", Required = true, HelpText = "Source Aggregator instance name.")]
         public string SourceInstance { get; set; }
 
-        [Option('d', "destInstance", Required = true, HelpText = "Destionation Aggregator instance name.")]
+        [Option('d', "destInstance", Required = true, HelpText = "Destination Aggregator instance name.")]
         public string DestInstance { get; set; }
 
         [Option('g', "resourceGroup", Required = false, Default = "", HelpText = "Azure Resource Group hosting the Aggregator instance.")]

src/aggregator-cli/Program.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Threading;
+using System.Threading.Tasks;
 using aggregator.cli.Instances;
 using CommandLine;
 using CommandLine.Text;
@@ -35,7 +36,7 @@ emulates the event on the rule
     */
     public static class Program
     {
-        public static int Main(string[] args)
+        public static async Task<int> Main(string[] args)
         {
             var mainTimer = new Stopwatch();
             mainTimer.Start();
@@ -63,7 +64,7 @@ void cancelEventHandler(object sender, ConsoleCancelEventArgs e)
                 {
                     var tempLogger = new ConsoleLogger(false);
                     var verChecker = new FunctionRuntimePackage(tempLogger);
-                    (bool upgrade, string newversion) = verChecker.IsCliUpgradable().Result;
+                    (bool upgrade, string newversion) = await verChecker.IsCliUpgradable();
                     if (upgrade)
                     {
                         // bug user

src/aggregator-cli/Rules/AggregatorRules.cs

@@ -164,7 +164,7 @@ internal async Task<bool> AddAsync(InstanceName instance, string ruleName, strin
             if (preprocessedRule.Impersonate)
             {
                 _logger.WriteInfo($"Configure {ruleName} to execute impersonated.");
-                ok &= await ConfigureAsync(instance, ruleName, impersonate: true, cancellationToken: cancellationToken);
+                ok &= await ConfigureAsync(instance, ruleName, impersonate: true, bypassrules: false, cancellationToken: cancellationToken);
                 if (ok)
                 {
                     _logger.WriteInfo($"Updated {ruleName} configuration successfully.");
@@ -339,7 +339,7 @@ internal async Task<bool> RemoveAsync(InstanceName instance, string name, Cancel
             return true;
         }
 
-        internal async Task<bool> ConfigureAsync(InstanceName instance, string name, bool? disable = null, bool? impersonate = null, CancellationToken cancellationToken = default)
+        internal async Task<bool> ConfigureAsync(InstanceName instance, string name, bool? disable = null, bool? impersonate = null, bool? bypassrules = null, CancellationToken cancellationToken = default)
         {
             var webFunctionApp = await GetWebApp(instance, cancellationToken);
             var configuration = await AggregatorConfiguration.ReadConfiguration(webFunctionApp);
@@ -355,6 +355,11 @@ internal async Task<bool> ConfigureAsync(InstanceName instance, string name, boo
                 ruleConfig.Impersonate = impersonate.Value;
             }
 
+            if (bypassrules.HasValue)
+            {
+                ruleConfig.BypassRules = impersonate.Value;
+            }
+
             ruleConfig.WriteConfiguration(webFunctionApp);
 
             return true;

src/aggregator-cli/Rules/ConfigureRuleCommand.cs

@@ -44,7 +44,7 @@ internal override async Task<int> RunAsync(CancellationToken cancellationToken)
             var disable = GetDisableStatus(Disable, Enable);
             var impersonate = GetEnableStatus(DisableImpersonateExecution, EnableImpersonateExecution);
 
-            var ok = await rules.ConfigureAsync(instance, Name, disable, impersonate, cancellationToken);
+            var ok = await rules.ConfigureAsync(instance, Name, disable, impersonate, false, cancellationToken);
             return ok ? ExitCodes.Success : ExitCodes.Failure;
         }
 

src/aggregator-ruleng/IRule.cs

@@ -18,6 +18,13 @@ public interface IRule
         /// <remarks>Setter public for CLI</remarks>
         bool ImpersonateExecution { get; set; }
 
+        /// <summary>
+        /// WorkItem creation/updates will bypass rules
+        /// Assumes PAT or Account Permission is high enough
+        /// </summary>
+        /// <remarks>Setter public for CLI</remarks>
+        bool BypassRules { get; set; }
+
         ///<summary>
         /// Configuration data picked by the directive parser that may influence a rule behaviour.
         ///</summary>

src/aggregator-ruleng/Language/IPreprocessedRule.cs

@@ -5,6 +5,7 @@ namespace aggregator.Engine.Language
 {
     public interface IPreprocessedRule
     {
+        bool BypassRules { get; set; }
         bool Impersonate { get; set; }
         IRuleSettings Settings { get; }
         RuleLanguage Language { get; }

src/aggregator-ruleng/Language/PreprocessedRule.cs

@@ -8,6 +8,7 @@ internal class PreprocessedRule : IPreprocessedRule
     {
         public PreprocessedRule()
         {
+            BypassRules = false;
             Impersonate = false;
             Settings = new RuleSettings();
             Language = RuleLanguage.Unknown;
@@ -20,6 +21,8 @@ public PreprocessedRule()
 
         public bool Impersonate { get; set; }
 
+        public bool BypassRules { get; set; }
+
         public IRuleSettings Settings { get; private set; }
 
         public RuleLanguage Language { get; internal set; }