Implicit navigation and better messages

Author: giuliov

.gitignore

@@ -333,5 +333,6 @@ ASALocalRun/
 # MFractors (Xamarin productivity tool) working folder 
 .mfractor/
 secrets/
-src/aggregator-cli/function-bin.zip
+src/aggregator-cli/FunctionRuntime.zip
 *.exe
+*.diagsession

src/aggregator-cli/test/test2.rule

@@ -10,7 +10,7 @@ if (self.Parent != null)
     }
     else
     {
-        message = "Parent was not closed";
+        message = "Parent was already closed";
     }
     parent.Description = parent.Description + " aggregator was here.";
 }

src/aggregator-function/AzureFunctionHandler.cs

@@ -34,7 +34,7 @@ public async Task<HttpResponseMessage> Run(HttpRequestMessage req)
             try
             {
                 string rule = context.FunctionName;
-                log.LogInformation($"Welcome to {rule}");
+                log.LogInformation($"Welcome to rule '{rule}'");
             }
             catch (Exception ex)
             {
@@ -86,7 +86,7 @@ public async Task<HttpResponseMessage> Run(HttpRequestMessage req)
                 }
                 else
                 {
-                    log.LogInformation($"Returning {execResult}");
+                    log.LogInformation($"Returning '{execResult}' from '{context.FunctionName}'");
 
                     var resp = new HttpResponseMessage(HttpStatusCode.OK)
                     {
@@ -97,7 +97,7 @@ public async Task<HttpResponseMessage> Run(HttpRequestMessage req)
             }
             catch (Exception ex)
             {
-                log.LogWarning($"Rule failed: {ex.Message}");
+                log.LogWarning($"Rule '{context.FunctionName}' failed: {ex.Message}");
 
                 var resp = new HttpResponseMessage(HttpStatusCode.NotImplemented)
                 {

src/aggregator-function/Engine/WorkItemStore.cs

@@ -61,8 +61,10 @@ public IList<WorkItemWrapper> GetWorkItems(IEnumerable<WorkItemRelationWrapper>
             return GetWorkItems(ids);
         }
 
-        internal void SaveChanges()
+        internal (int created, int updated) SaveChanges()
         {
+            int created = 0;
+            int updated = 0;
             foreach (var item in _context.Tracker.NewWorkItems)
             {
                 _context.Logger.WriteInfo($"Creating a {item.WorkItemType} workitem in {item.TeamProject}");
@@ -71,6 +73,7 @@ internal void SaveChanges()
                     item.TeamProject,
                     item.WorkItemType
                 );
+                created++;
             }
 
             foreach (var item in _context.Tracker.ChangedWorkItems)
@@ -80,7 +83,9 @@ internal void SaveChanges()
                     item.Changes,
                     item.Id.Value
                 );
+                updated++;
             }
+            return (created, updated);
         }
     }
 }

src/aggregator-function/Engine/WorkItemWrapper.cs

@@ -140,7 +140,7 @@ public IEnumerable<WorkItemRelationWrapper> Relations
             }
         }
 
-        public IEnumerable<WorkItemRelationWrapper> Children
+        public IEnumerable<WorkItemRelationWrapper> ChildrenLinks
         {
             get
             {
@@ -149,6 +149,15 @@ public IEnumerable<WorkItemRelationWrapper> Children
             }
         }
 
+        public IEnumerable<WorkItemWrapper> Children
+        {
+            get
+            {
+                var store = new WorkItemStore(_context);
+                return store.GetWorkItems(ChildrenLinks);
+            }
+        }
+
         public IEnumerable<WorkItemRelationWrapper> RelatedLinks
         {
             get
@@ -167,7 +176,7 @@ public IEnumerable<WorkItemRelationWrapper> Hyperlinks
             }
         }
 
-        public WorkItemRelationWrapper Parent
+        public WorkItemRelationWrapper ParentLink
         {
             get
             {
@@ -177,6 +186,15 @@ public WorkItemRelationWrapper Parent
             }
         }
 
+        public WorkItemWrapper Parent
+        {
+            get
+            {
+                var store = new WorkItemStore(_context);
+                return store.GetWorkItem(ParentLink);
+            }
+        }
+
         public WorkItemId<int> Id
         {
             get;

src/aggregator-function/RuleWrapper.cs

@@ -108,9 +108,16 @@ internal async Task<string> Execute(string aggregatorVersion, dynamic data)
                 logger.WriteInfo($"Rule succeeded, no return value");
             }
 
-            logger.WriteVerbose($"Post-execution, save all changes...");
-            store.SaveChanges();
-            logger.WriteInfo($"Changes saved to VSTS");
+            logger.WriteVerbose($"Post-execution, save any change...");
+            var saveRes = store.SaveChanges();
+            if (saveRes.created + saveRes.updated > 0)
+            {
+                logger.WriteInfo($"Changes saved to VSTS: {saveRes.created} created, {saveRes.updated} updated.");
+            }
+            else
+            {
+                logger.WriteInfo($"No changes saved to VSTS.");
+            }
 
             return result.ReturnValue;
         }

src/aggregator-function/test/test.rule

@@ -10,5 +10,20 @@ if (self.Parent != null)
     parent.Description = parent.Description + " aggregator was here.";
 }
 return $"Hello { self.WorkItemType } #{ self.Id } - { self.Title }!";
-*/
 return self.PreviousRevision.PreviousRevision.Description;
+*/
+if (self.ParentLink != null)
+{
+    var parent = self.Parent;
+    var children = parent.Children;
+    if (children.All(c => c.State == "Closed"))
+    {
+        parent.State = "Closed";
+		return "Had to close parent";
+    } else {
+		return "Not all children are closed";
+	}
+    //parent.Description = parent.Description + " aggregator was here.";
+} else {
+	return "No parent!";
+}