Skip to content

Commit f031f61

Browse files
authored
Merge pull request #48 from kbarbounakis/trim-zero-scale
Trim zero scale type
2 parents 5e58d30 + d3fa6f2 commit f031f61

File tree

3 files changed

+16
-4
lines changed

3 files changed

+16
-4
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@themost/sqlite",
3-
"version": "2.6.5",
3+
"version": "2.6.7",
44
"description": "MOST Web Framework SQLite Adapter",
55
"main": "dist/index.js",
66
"types": "dist/index.d.ts",

src/SqliteAdapter.js

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import { SqliteFormatter } from './SqliteFormatter';
88
import sqlite from 'sqlite3';
99
const sqlite3 = sqlite.verbose();
1010
const SqlDateRegEx = /^\d{4}-\d{2}-\d{2}\s\d{2}:\d{2}:\d{2}\.\d+\+[0-1][0-9]:[0-5][0-9]$/;
11+
1112
/**
1213
* @class
1314
* @augments DataAdapter
@@ -457,7 +458,18 @@ class SqliteAdapter {
457458
}
458459
else {
459460
newType = format('%t', x);
460-
oldType = column.type.toUpperCase().concat(column.nullable ? ' NOT NULL' : ' NULL');
461+
oldType = column.type.toUpperCase().concat(column.nullable ? ' NULL' : ' NOT NULL');
462+
// trim zero scale for both new and old type
463+
// e.g. TEXT(50,0) to TEXT(50)
464+
const reTrimScale = /^(NUMERIC|TEXT|INTEGER)\((\d+)(,0)\)/g;
465+
if (reTrimScale.test(newType) === true) {
466+
// trim
467+
newType = newType.replace(reTrimScale, '$1($2)');
468+
}
469+
if (reTrimScale.test(oldType) === true) {
470+
// trim
471+
oldType = oldType.replace(reTrimScale, '$1($2)');
472+
}
461473
if (newType === oldType) {
462474
//remove column from add collection
463475
migration.add.splice(i, 1);

0 commit comments

Comments
 (0)