shellcheck fixes

Signed-off-by: Emilia Kurdybelska <emiliax.kurdybelska@intel.com>

Author: ekurdybx

test-case/check-fw-echo-reference.sh

@@ -65,7 +65,7 @@ do
     fi
 done
 
-for i in $(seq 1 $loop_cnt)
+for i in $(seq 1 "$loop_cnt")
 do
     for fmt in $fmts
     do

test-case/check-ipc-flood.sh

@@ -46,12 +46,12 @@ sof-kernel-dump.sh | grep sof-audio | grep -q "Firmware debug" ||
 func_lib_check_sudo
 
 dlogi "Check $ipc_flood_dfs"
-sudo test -e $ipc_flood_dfs ||
+sudo test -e "$ipc_flood_dfs" ||
   skip_test "${BASH_SOURCE[0]} need $ipc_flood_dfs to run the test case"
 
 dlogi "Running ipc flood test!"
 
-for i in $(seq 1 $loop_cnt)
+for i in $(seq 1 "$loop_cnt")
 do
     # TODO: use journalctl to replace dmesg
     # cleanup dmesg buffer for each iteration

test-case/check-keyword-detection.sh

@@ -106,7 +106,7 @@ _restore_default_wov_config_bolb()
 # update the blob
 _update_blob(){
     new_blob=$test_dir"/new_blob"
-    [ $preamble_time -ge $history_depth ] || {
+    [ "$preamble_time" -ge "$history_depth" ] || {
         die "Warning: invalid arguments, preamble_time must be greater than or equal to history_depth"
     }
     awk -F, -v OFS=, '{if ( $4 == '"$def_pt"' && $7 == '"$def_hd"' ) $4='"$preamble_time"'; $7='"$history_depth"'}1' \

test-case/check-kmod-load-unload.sh

@@ -48,7 +48,7 @@ if [ ${OPT_VAL['p']} -eq 1 ];then
     func_lib_disable_pulseaudio
 fi
 
-for idx in $(seq 1 $loop_cnt)
+for idx in $(seq 1 "$loop_cnt")
 do
     dlogi "===== Starting iteration $idx of $loop_cnt ====="
     ## - 1: remove module section

test-case/check-pause-release-suspend-resume.sh

@@ -115,6 +115,8 @@ esac
 
 logger_disabled || func_lib_start_log_collect
 
+setup_kernel_check_point
+
 dlogi "Entering audio stream expect script with: $cmd -D $pcm -r $rate -c $channel -f $fmt -vv -i $dummy_file -q"
 dlogi "Will enter suspend-resume cycle during paused period of audio stream process"
 

test-case/check-runtime-pm-status.sh

@@ -17,7 +17,7 @@
 ##    no error in dmesg
 ##
 
-source $(dirname ${BASH_SOURCE[0]})/../case-lib/lib.sh
+source "$(dirname ${BASH_SOURCE[0]})/../case-lib/lib.sh"
 
 OPT_NAME['t']='tplg'     OPT_DESC['t']='tplg file, default value is env TPLG: $TPLG'
 OPT_HAS_ARG['t']=1         OPT_VAL['t']="$TPLG"
@@ -28,7 +28,9 @@ OPT_HAS_ARG['l']=1         OPT_VAL['l']=3
 OPT_NAME['d']='delay'    OPT_DESC['d']='max delay time for state convert'
 OPT_HAS_ARG['d']=1         OPT_VAL['d']=15
 
+# shellcheck disable=SC2034
 OPT_NAME['s']='sof-logger'   OPT_DESC['s']="Open sof-logger trace the data will store at $LOG_ROOT"
+# shellcheck disable=SC2034
 OPT_HAS_ARG['s']=0             OPT_VAL['s']=1
 
 # param: $1 -> max delay time for dsp pm status switch
@@ -70,15 +72,16 @@ DEV_LST['capture']='/dev/null'
 logger_disabled || func_lib_start_log_collect
 func_pipeline_export "$tplg" "type:any"
 
-for idx in $(seq 0 $(expr $PIPELINE_COUNT - 1))
+# shellcheck disable=SC2046
+for idx in $(seq 0 $(expr "$PIPELINE_COUNT" - 1))
 do
-    channel=$(func_pipeline_parse_value $idx channel)
-    rate=$(func_pipeline_parse_value $idx rate)
-    fmt=$(func_pipeline_parse_value $idx fmt)
-    dev=$(func_pipeline_parse_value $idx dev)
-    pcm=$(func_pipeline_parse_value $idx pcm)
-    type=$(func_pipeline_parse_value $idx type)
-    snd=$(func_pipeline_parse_value $idx snd)
+    channel=$(func_pipeline_parse_value "$idx" channel)
+    rate=$(func_pipeline_parse_value "$idx" rate)
+    fmt=$(func_pipeline_parse_value "$idx" fmt)
+    dev=$(func_pipeline_parse_value "$idx" dev)
+    pcm=$(func_pipeline_parse_value "$idx" pcm)
+    type=$(func_pipeline_parse_value "$idx" type)
+    snd=$(func_pipeline_parse_value "$idx" snd)
 
     cmd="${APP_LST[$type]}"
     dummy_file="${DEV_LST[$type]}"