shellcheck fixes

Signed-off-by: Emilia Kurdybelska <emiliax.kurdybelska@intel.com>

Author: ekurdybx

test-case/check-fw-echo-reference.sh

@@ -65,7 +65,7 @@ do
     fi
 done
 
-for i in $(seq 1 $loop_cnt)
+for i in $(seq 1 "$loop_cnt")
 do
     for fmt in $fmts
     do

test-case/check-ipc-flood.sh

@@ -46,12 +46,12 @@ sof-kernel-dump.sh | grep sof-audio | grep -q "Firmware debug" ||
 func_lib_check_sudo
 
 dlogi "Check $ipc_flood_dfs"
-sudo test -e $ipc_flood_dfs ||
+sudo test -e "$ipc_flood_dfs" ||
   skip_test "${BASH_SOURCE[0]} need $ipc_flood_dfs to run the test case"
 
 dlogi "Running ipc flood test!"
 
-for i in $(seq 1 $loop_cnt)
+for i in $(seq 1 "$loop_cnt")
 do
     # TODO: use journalctl to replace dmesg
     # cleanup dmesg buffer for each iteration

test-case/check-keyword-detection.sh

@@ -106,7 +106,7 @@ _restore_default_wov_config_bolb()
 # update the blob
 _update_blob(){
     new_blob=$test_dir"/new_blob"
-    [ $preamble_time -ge $history_depth ] || {
+    [ "$preamble_time" -ge "$history_depth" ] || {
         die "Warning: invalid arguments, preamble_time must be greater than or equal to history_depth"
     }
     awk -F, -v OFS=, '{if ( $4 == '"$def_pt"' && $7 == '"$def_hd"' ) $4='"$preamble_time"'; $7='"$history_depth"'}1' \

test-case/check-kmod-load-unload.sh

@@ -44,11 +44,11 @@ loop_cnt=${OPT_VAL['l']}
 PATH="${PATH%%:*}/kmod:$PATH"
 func_lib_check_sudo 'unloading modules'
 
-if [ ${OPT_VAL['p']} -eq 1 ];then
+if [ "${OPT_VAL['p']}" -eq 1 ];then
     func_lib_disable_pulseaudio
 fi
 
-for idx in $(seq 1 $loop_cnt)
+for idx in $(seq 1 "$loop_cnt")
 do
     dlogi "===== Starting iteration $idx of $loop_cnt ====="
     ## - 1: remove module section

test-case/check-pause-release-suspend-resume.sh

@@ -115,6 +115,8 @@ esac
 
 logger_disabled || func_lib_start_log_collect
 
+setup_kernel_check_point
+
 dlogi "Entering audio stream expect script with: $cmd -D $pcm -r $rate -c $channel -f $fmt -vv -i $dummy_file -q"
 dlogi "Will enter suspend-resume cycle during paused period of audio stream process"
 

test-case/check-runtime-pm-status.sh

@@ -50,6 +50,7 @@ func_check_dsp_status()
 }
 
 func_opt_parse_option "$@"
+setup_kernel_check_point
 
 tplg=${OPT_VAL['t']}
 loop_count=${OPT_VAL['l']}

test-case/check-signal-stop-start.sh

@@ -63,7 +63,7 @@ esac
 func_stop_start_pipeline()
 {
     local i=1
-    while [ $i -le $count ]
+    while [ $i -le "$count" ]
     do
         # check aplay/arecord process state
         sof-process-state.sh "$pid" >/dev/null || {
@@ -74,10 +74,10 @@ func_stop_start_pipeline()
         dlogi "Stop/start count: $i"
         # stop the pipeline
         kill -SIGSTOP "$pid"
-        sleep $interval
+        sleep "$interval"
         # start the pipeline
         kill -SIGCONT "$pid"
-        sleep $interval
+        sleep "$interval"
         (( i++ ))
     done
 }

test-case/check-smart-amplifier.sh

@@ -80,11 +80,11 @@ do
 done
 
 fmts="$cp_fmt"
-if [ ${OPT_VAL['F']} = '1' ]; then
+if [ "${OPT_VAL['F']}" = '1' ]; then
     fmts="$cp_fmts"
 fi
 
-for i in $(seq 1 $loop_cnt)
+for i in $(seq 1 "$loop_cnt")
 do
     for fmt in $fmts
     do

test-case/check-suspend-resume-with-audio.sh

@@ -85,7 +85,7 @@ opt_arr=(-l "${OPT_VAL['l']}")
 if [ "${OPT_VAL['T']}" ]; then
     opt_arr+=(-T "${OPT_VAL['T']}")
 fi
-if [ ${OPT_VAL['r']} -eq 0  ]; then
+if [ "${OPT_VAL['r']}" -eq 0  ]; then
     opt_arr+=(-S "${OPT_VAL['S']}" -w "${OPT_VAL['w']}")
 else
     opt_arr+=(-r)
@@ -102,6 +102,7 @@ do
     fmt=$(func_pipeline_parse_value "$idx" fmt)
     dev=$(func_pipeline_parse_value "$idx" dev)
     snd=$(func_pipeline_parse_value "$idx" snd)
+    # shellcheck disable=SC2153
     dlogi "Run $TYPE command for the background"
     cmd_args="$cmd -D$dev -r $rate -c $channel -f $fmt $file_name -q"
     dlogc "$cmd_args"

test-case/check-userspace-paplay.sh

@@ -59,7 +59,7 @@ channel=${OPT_VAL['C']}
 # go through all the sinks
 # get all the sinks name
 sinkkeys=$(pactlinfo.py --showsinks)
-for round in $(seq 1 $round_cnt); do
+for round in $(seq 1 "$round_cnt"); do
     for i in $sinkkeys; do
         sinkcard=$(pactlinfo.py --getsinkcardname "$i") || {
             dlogw "failed to get sink $i card_name"
@@ -93,10 +93,11 @@ for round in $(seq 1 $round_cnt); do
             sinkname=$(eval echo "$sinkname")
             dlogi "===== Testing: (Round: $round/$round_cnt) (sink: $sinkname.$actport) ====="
             dlogc "paplay -v --device=$sinkname --raw --rate=$rate --format=$format --channels=$channel $file"
-            paplay -v --device="$sinkname" --raw --rate=$rate --format=$format --channels=$channel $file &
+            paplay -v --device="$sinkname" --raw --rate="$rate" --format="$format" --channels="$channel" "$file" &
             pid=$!
-            sleep $duration
+            sleep "$duration"
             # check whether process is still running
+            # shellcheck disable=SC2009
             count=$(ps -A| grep -c $pid) || true
             if [[ $count -eq 0 ]]; then
                 if wait $pid; then #checks if process executed successfully or not