Skip to content

Commit 1dad327

Browse files
tlissowsserhiy-katsyuba-intel
authored andcommitted
dai: uaol: add support for Intel UAOL
Adds support for Intel USB Audio Offload Link (UAOL) DAI. Signed-off-by: Tomasz Lissowski <tomasz.lissowski@intel.com> Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
1 parent 7cf3d8a commit 1dad327

File tree

7 files changed

+140
-3
lines changed

7 files changed

+140
-3
lines changed

src/audio/base_fw_intel.c

Lines changed: 92 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@
2424
#include <sof/lib/memory.h>
2525
#include <sof/lib_manager.h>
2626

27+
#if CONFIG_UAOL_INTEL_ADSP
28+
#include <zephyr/drivers/uaol.h>
29+
#endif
30+
2731
#include <ipc4/base_fw.h>
2832
#include <ipc4/alh.h>
2933
#include <rimage/sof/user/manifest.h>
@@ -41,6 +45,23 @@ struct ipc4_modules_info {
4145
/* Sanity check because a subtraction of those sizes is performed later on */
4246
STATIC_ASSERT(sizeof(struct ipc4_modules_info) < SOF_IPC_MSG_MAX_SIZE,
4347
invalid_modules_info_struct_size);
48+
49+
#if CONFIG_UAOL_INTEL_ADSP
50+
struct ipc4_uaol_link_capabilities {
51+
uint32_t input_streams_supported : 4;
52+
uint32_t output_streams_supported : 4;
53+
uint32_t bidirectional_streams_supported : 5;
54+
uint32_t rsvd : 19;
55+
uint32_t max_tx_fifo_size;
56+
uint32_t max_rx_fifo_size;
57+
} __packed __aligned(4);
58+
59+
struct ipc4_uaol_capabilities {
60+
uint32_t link_count;
61+
struct ipc4_uaol_link_capabilities link_caps[];
62+
} __packed __aligned(4);
63+
#endif /* CONFIG_UAOL_INTEL_ADSP */
64+
4465
/*
4566
* TODO: default to value of ACE1.x platforms. This is defined
4667
* in multiple places in Zephyr, mm_drv_intel_adsp.h and
@@ -71,7 +92,7 @@ __cold int basefw_vendor_fw_config(uint32_t *data_offset, char *data)
7192
tlv_value_uint32_set(tuple, IPC4_SLOW_CLOCK_FREQ_HZ_FW_CFG, IPC4_ALH_CAVS_1_8);
7293

7394
tuple = tlv_next(tuple);
74-
tlv_value_uint32_set(tuple, IPC4_UAOL_SUPPORT, 0);
95+
tlv_value_uint32_set(tuple, IPC4_UAOL_SUPPORT, IS_ENABLED(CONFIG_UAOL_INTEL_ADSP));
7596

7697
tuple = tlv_next(tuple);
7798
tlv_value_uint32_set(tuple, IPC4_ALH_SUPPORT_LEVEL_FW_CFG, IPC4_ALH_CAVS_1_8);
@@ -82,6 +103,55 @@ __cold int basefw_vendor_fw_config(uint32_t *data_offset, char *data)
82103
return 0;
83104
}
84105

106+
#if CONFIG_UAOL_INTEL_ADSP
107+
#define DEV_AND_COMMA(node) DEVICE_DT_GET(node),
108+
static const struct device *uaol_devs[] = {
109+
DT_FOREACH_STATUS_OKAY(intel_adsp_uaol, DEV_AND_COMMA)
110+
};
111+
112+
static void tlv_value_set_uaol_caps(struct sof_tlv *tuple, uint32_t type)
113+
{
114+
const size_t dev_count = ARRAY_SIZE(uaol_devs);
115+
struct uaol_capabilities dev_cap;
116+
struct ipc4_uaol_capabilities *caps = (struct ipc4_uaol_capabilities *)tuple->value;
117+
size_t caps_size = offsetof(struct ipc4_uaol_capabilities, link_caps[dev_count]);
118+
size_t i;
119+
int ret;
120+
121+
memset(caps, 0, caps_size);
122+
123+
caps->link_count = dev_count;
124+
for (i = 0; i < dev_count; i++) {
125+
ret = uaol_get_capabilities(uaol_devs[i], &dev_cap);
126+
if (ret)
127+
continue;
128+
129+
caps->link_caps[i].input_streams_supported = dev_cap.input_streams;
130+
caps->link_caps[i].output_streams_supported = dev_cap.output_streams;
131+
caps->link_caps[i].bidirectional_streams_supported = dev_cap.bidirectional_streams;
132+
caps->link_caps[i].max_tx_fifo_size = dev_cap.max_tx_fifo_size;
133+
caps->link_caps[i].max_rx_fifo_size = dev_cap.max_rx_fifo_size;
134+
}
135+
136+
tlv_value_set(tuple, type, caps_size, caps);
137+
}
138+
139+
static int uaol_stream_id_to_hda_link_stream_id(int uaol_stream_id)
140+
{
141+
size_t dev_count = ARRAY_SIZE(uaol_devs);
142+
size_t i;
143+
144+
for (i = 0; i < dev_count; i++) {
145+
int hda_link_stream_id = uaol_get_mapped_hda_link_stream_id(uaol_devs[i],
146+
uaol_stream_id);
147+
if (hda_link_stream_id >= 0)
148+
return hda_link_stream_id;
149+
}
150+
151+
return -1;
152+
}
153+
#endif /* CONFIG_UAOL_INTEL_ADSP */
154+
85155
__cold int basefw_vendor_hw_config(uint32_t *data_offset, char *data)
86156
{
87157
struct sof_tlv *tuple = (struct sof_tlv *)data;
@@ -124,6 +194,11 @@ __cold int basefw_vendor_hw_config(uint32_t *data_offset, char *data)
124194
tlv_value_set(tuple, IPC4_INTEL_MIC_PRIVACY_CAPS_HW_CFG, sizeof(priv_caps), &priv_caps);
125195
#endif
126196

197+
#if CONFIG_UAOL_INTEL_ADSP
198+
tuple = tlv_next(tuple);
199+
tlv_value_set_uaol_caps(tuple, IPC4_UAOL_CAPS_HW_CFG);
200+
#endif
201+
127202
tuple = tlv_next(tuple);
128203
*data_offset = (int)((char *)tuple - data);
129204

@@ -454,6 +529,7 @@ __cold int basefw_vendor_set_large_config(struct comp_dev *dev, uint32_t param_i
454529
__cold int basefw_vendor_dma_control(uint32_t node_id, const char *config_data, size_t data_size)
455530
{
456531
union ipc4_connector_node_id node = (union ipc4_connector_node_id)node_id;
532+
int dai_index = node.f.v_index;
457533
int ret, result;
458534
enum sof_ipc_dai_type type;
459535

@@ -477,11 +553,25 @@ __cold int basefw_vendor_dma_control(uint32_t node_id, const char *config_data,
477553
case ipc4_i2s_link_input_class:
478554
type = SOF_DAI_INTEL_SSP;
479555
break;
556+
557+
#if CONFIG_UAOL_INTEL_ADSP
558+
case ipc4_alh_uaol_stream_link_output_class:
559+
case ipc4_alh_uaol_stream_link_input_class:
560+
type = SOF_DAI_INTEL_UAOL;
561+
dai_index = uaol_stream_id_to_hda_link_stream_id(node.f.v_index);
562+
if (dai_index < 0) {
563+
tr_err(&basefw_comp_tr,
564+
"HDA link stream not found! UAOL node ID: 0x%x", node_id);
565+
return IPC4_INVALID_RESOURCE_ID;
566+
}
567+
break;
568+
#endif
569+
480570
default:
481571
return IPC4_INVALID_RESOURCE_ID;
482572
}
483573

484-
const struct device *dev = dai_get_device(type, node.f.v_index);
574+
const struct device *dev = dai_get_device(type, dai_index);
485575

486576
if (!dev) {
487577
tr_err(&basefw_comp_tr,

src/audio/copier/copier.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,8 @@ __cold static int copier_init(struct processing_module *mod)
191191
case ipc4_i2s_link_input_class:
192192
case ipc4_alh_link_output_class:
193193
case ipc4_alh_link_input_class:
194+
case ipc4_alh_uaol_stream_link_output_class:
195+
case ipc4_alh_uaol_stream_link_input_class:
194196
ret = copier_dai_create(dev, cd, copier, dev->pipeline);
195197
if (ret < 0) {
196198
comp_err(dev, "unable to create dai");

src/audio/copier/copier_dai.c

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -322,6 +322,17 @@ __cold int copier_dai_create(struct comp_dev *dev, struct copier_data *cd,
322322
if (ret)
323323
return ret;
324324
break;
325+
case ipc4_alh_uaol_stream_link_output_class:
326+
case ipc4_alh_uaol_stream_link_input_class:
327+
dai.type = SOF_DAI_INTEL_UAOL;
328+
dai.is_config_blob = true;
329+
cd->gtw_type = ipc4_gtw_alh;
330+
ret = ipc4_find_dma_config(&dai, gtw_cfg_data, gtw_cfg_szie);
331+
if (ret != IPC4_SUCCESS) {
332+
comp_err(dev, "No uaol dma_config found in blob!");
333+
return -EINVAL;
334+
}
335+
break;
325336
case ipc4_dmic_link_input_class:
326337
dai.type = SOF_DAI_INTEL_DMIC;
327338
dai.is_config_blob = true;

src/audio/dai-zephyr.c

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,18 @@ __cold int dai_set_config(struct dai *dai, struct ipc_config_dai *common_config,
191191
cfg.type = DAI_IMX_MICFIL;
192192
cfg_params = &sof_cfg->micfil;
193193
break;
194+
case SOF_DAI_INTEL_UAOL:
195+
cfg.type = DAI_INTEL_UAOL;
196+
cfg.channels = common_config->gtw_fmt->channels_count;
197+
/*
198+
* FIXME: The spec says HW expects container size here, not valid_bit_depth.
199+
* However, tests fail if container size is used and work fine with
200+
* valid_bit_depth. Needs investigation. Perhaps tests have a bug?
201+
*/
202+
cfg.word_size = common_config->gtw_fmt->valid_bit_depth;
203+
cfg_params = spec_config;
204+
dai_set_link_hda_config(&cfg.link_config, common_config, spec_config);
205+
break;
194206
default:
195207
return -EINVAL;
196208
}

src/include/ipc/dai.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,8 @@ enum sof_ipc_dai_type {
9494
SOF_DAI_AMD_SP_VIRTUAL, /**<Amd SP VIRTUAL */
9595
SOF_DAI_AMD_HS_VIRTUAL, /**<Amd HS VIRTUAL */
9696
SOF_DAI_IMX_MICFIL, /**< i.MX MICFIL */
97-
SOF_DAI_AMD_SW_AUDIO /**<Amd SW AUDIO */
97+
SOF_DAI_AMD_SW_AUDIO, /**<Amd SW AUDIO */
98+
SOF_DAI_INTEL_UAOL, /**< Intel UAOL */
9899
};
99100

100101
/* general purpose DAI configuration */

src/ipc/ipc4/dai.c

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,12 @@ void dai_set_link_hda_config(uint16_t *link_config,
6060
}
6161
link_cfg.part.stream = common_config->host_dma_config[0]->stream_id;
6262
break;
63+
case SOF_DAI_INTEL_UAOL:
64+
link_cfg.full = 0;
65+
link_cfg.part.hchan = gtw_fmt->channels_count - 1;
66+
link_cfg.part.dir = common_config->direction;
67+
link_cfg.part.stream = common_config->host_dma_config[0]->stream_id;
68+
break;
6369
default:
6470
/* other types of DAIs not need link_config */
6571
return;
@@ -112,6 +118,13 @@ int dai_config_dma_channel(struct dai_data *dd, struct comp_dev *dev, const void
112118
*/
113119
channel = 0;
114120
break;
121+
#if ACE_VERSION > ACE_VERSION_1_5
122+
case SOF_DAI_INTEL_UAOL:
123+
channel = 0;
124+
if (dai->host_dma_config[0]->pre_allocated_by_host)
125+
channel = dai->host_dma_config[0]->dma_channel_id;
126+
break;
127+
#endif
115128
default:
116129
/* other types of DAIs not handled for now */
117130
comp_err(dev, "Unknown dai type %d", dai->type);
@@ -173,6 +186,8 @@ int ipc_dai_data_config(struct dai_data *dd, struct comp_dev *dev)
173186
comp_dbg(dev, "dai_data_config() SOF_DAI_INTEL_ALH dev->ipc_config.frame_fmt: %d, stream_id: %d",
174187
dev->ipc_config.frame_fmt, dd->stream_id);
175188

189+
break;
190+
case SOF_DAI_INTEL_UAOL:
176191
break;
177192
default:
178193
/* other types of DAIs not handled for now */

src/lib/dai.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,9 @@ const struct device *zephyr_dev[] = {
185185
#if CONFIG_DAI_NXP_MICFIL
186186
DT_FOREACH_STATUS_OKAY(nxp_dai_micfil, GET_DEVICE_LIST)
187187
#endif
188+
#if CONFIG_DAI_INTEL_UAOL
189+
DT_FOREACH_STATUS_OKAY(intel_uaol_dai, GET_DEVICE_LIST)
190+
#endif
188191
};
189192

190193
const struct device **dai_get_device_list(size_t *count)
@@ -207,6 +210,8 @@ static int sof_dai_type_to_zephyr(uint32_t type)
207210
return DAI_INTEL_HDA;
208211
case SOF_DAI_INTEL_ALH:
209212
return DAI_INTEL_ALH;
213+
case SOF_DAI_INTEL_UAOL:
214+
return DAI_INTEL_UAOL;
210215
case SOF_DAI_IMX_SAI:
211216
return DAI_IMX_SAI;
212217
case SOF_DAI_IMX_ESAI:
@@ -285,6 +290,7 @@ static void dai_set_device_params(struct dai *d)
285290
#endif
286291
break;
287292
case SOF_DAI_INTEL_HDA:
293+
case SOF_DAI_INTEL_UAOL:
288294
d->dma_dev = SOF_DMA_DEV_HDA;
289295
d->dma_caps = SOF_DMA_CAP_HDA;
290296
break;

0 commit comments

Comments
 (0)