refactor: removed direct ini_set() usage, now using Symfony ErrorHandler

Author: thorsten

CHANGELOG.md

@@ -22,12 +22,12 @@ This is a log of major user-visible changes in each phpMyFAQ release.
 - added Urdu translation (Thorsten)
 - added dark mode / light mode toggle (Thorsten)
 - added support for PHP 8.5 (Thorsten)
+- added support for .env files (Thorsten)
 - added experimental support for FrankenPHP (Thorsten)
 - added experimental support for OpenSearch (Thorsten)
 - added experimental support for LDAP group support (Thorsten)
 - added experimental MCP Server (Thorsten)
 - added experimental update via command line (Thorsten)
-- added experimental support for .env files (Thorsten)
 - added experimental support for Mago (Thorsten)
 - improved online update feature (Thorsten)
 - updated Spanish translation (Thorsten)

composer.json

@@ -40,6 +40,7 @@
     "symfony/dependency-injection": "^7.3",
     "symfony/dotenv": "^7.3",
     "symfony/event-dispatcher": "^7.3",
+    "symfony/error-handler": "^7.3",
     "symfony/html-sanitizer": "^7.3",
     "symfony/http-client": "^7.3",
     "symfony/http-foundation": "^7.3",

composer.lock

@@ -1,6 +1,5 @@
 # Debug Configuration
 DEBUG=false
-DEBUG_LEVEL=0
 DEBUG_LOG_QUERIES=false
 
 # Application Configuration

phpmyfaq/.env.example

@@ -6,20 +6,19 @@
  * It preloads phpMyFAQ's bootstrap and handles requests in a long-running process.
  * 
  * @package phpMyFAQ
- * @author  phpMyFAQ Team
- * @since   2025-01-01
+ *  @author    Thorsten Rinne <[email protected]>
+ *  @copyright 2025 phpMyFAQ Team
+ *  @license   https://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
+ *  @link      https://www.phpmyfaq.de
+ *  @since     2025-07-06
  */
 
-// Set up error reporting
-error_reporting(E_ALL);
-ini_set('display_errors', 1);
-
-// Include phpMyFAQ bootstrap
+// Include phpMyFAQ bootstrap (sets up error handling via Environment)
 require_once __DIR__ . '/src/Bootstrap.php';
 
 // FrankenPHP worker loop
-while ($worker = \frankenphp_handle_request()) {
+while ($worker = frankenphp_handle_request()) {
     // The worker will handle each request here
-    // phpMyFAQ's routing and processing will be handled by the main application
+    // the main application will handle phpMyFAQ's routing and processing
     // through the Bootstrap.php inclusion
-}
+}

phpmyfaq/frankenphp-worker.php

@@ -175,6 +175,16 @@
     $searchResult = '';
     $relTags = '';
     $tags = [];
+
+    // Set the base URL scheme for fulltext search
+    $baseUrl = sprintf(
+        '%ssearch.html?search=%s&seite=%d%s&pmf-search-category=%d',
+        $faqConfig->getDefaultUrl(),
+        urlencode($inputSearchTerm),
+        $page,
+        $languages,
+        $inputCategory,
+    );
 }
 
 //
@@ -257,7 +267,7 @@
 $options = [
     'baseUrl' => $baseUrl,
     'total' => $numOfResults,
-    'perPage' => $faqConfig->get('records.numberOfRecordsPerPage'),
+    'perPage' => (int) $faqConfig->get('records.numberOfRecordsPerPage'),
     'pageParamName' => 'seite',
     'layoutTpl' => '<ul class="pagination justify-content-center">{LAYOUT_CONTENT}</ul>',
 ];

phpmyfaq/search.php

@@ -27,10 +27,6 @@
 use Symfony\Component\HttpFoundation\Session\Session;
 use Symfony\Component\HttpFoundation\Session\Storage\PhpBridgeSessionStorage;
 
-ini_set('display_errors', '1');
-ini_set('display_startup_errors', '1');
-error_reporting(-1);
-
 if (session_status() !== PHP_SESSION_ACTIVE) {
     session_start();
     session_regenerate_id(true);
@@ -115,5 +111,3 @@
 } else {
     $redirect->send();
 }
-
-

phpmyfaq/services/azure/callback.php

@@ -31,10 +31,6 @@
 use Symfony\Component\HttpFoundation\Session\Session;
 use Symfony\Component\HttpFoundation\Session\Storage\PhpBridgeSessionStorage;
 
-ini_set('display_errors', '1');
-ini_set('display_startup_errors', '1');
-error_reporting(-1);
-
 //
 // Fix the PHP include path if PMF is running under a "strange" PHP configuration
 //
@@ -48,7 +44,7 @@
     ++$i;
 }
 if (!$foundCurrPath) {
-    ini_set('include_path', '.' . PATH_SEPARATOR . ini_get('include_path'));
+    set_include_path('.' . PATH_SEPARATOR . get_include_path());
 }
 
 //
@@ -121,8 +117,8 @@
 //
 // Set the error handler and the exception handler
 //
-set_error_handler('\phpMyFAQ\Core\Error::errorHandler');
-set_exception_handler('\phpMyFAQ\Core\Error::exceptionHandler');
+set_error_handler('\\phpMyFAQ\\Core\\Error::errorHandler');
+set_exception_handler('\\phpMyFAQ\\Core\\Error::exceptionHandler');
 
 //
 // Request
@@ -163,22 +159,20 @@
 // We always need a valid, secure session!
 //
 if (session_status() !== PHP_SESSION_ACTIVE) {
-    ini_set('session.use_only_cookies', '1'); // Avoid any PHP version to move sessions on URLs
-    ini_set('session.auto_start', '0'); // Prevent error to use session_start() if it's active in php.ini
-    ini_set('session.use_trans_sid', '0');
-    ini_set('session.cookie_samesite', 'Strict');
-    ini_set('session.cookie_httponly', 'true');
-    ini_set('session.cookie_secure', $request->isSecure());
-    ini_set('url_rewriter.tags', '');
-
-    //
+    $sessionOptions = [
+        'use_only_cookies' => 1,
+        'use_trans_sid' => 0,
+        'cookie_samesite' => 'Strict',
+        'cookie_httponly' => true,
+        'cookie_secure' => $request->isSecure(),
+    ];
+
     // Start the PHP session
-    //
     if (defined('PMF_SESSION_SAVE_PATH') && !empty(PMF_SESSION_SAVE_PATH)) {
-        session_save_path(PMF_SESSION_SAVE_PATH);
+        $sessionOptions['save_path'] = PMF_SESSION_SAVE_PATH;
     }
 
-    session_start();
+    session_start($sessionOptions);
     $session = new Session(new PhpBridgeSessionStorage());
     $session->start();
 }

phpmyfaq/src/Bootstrap.php

@@ -76,7 +76,6 @@ public function setDatabase(DatabaseDriver $databaseDriver): void
 
     /**
      * Sets the Monolog logger instance, logs into a normal logfile
-     * If DEBUG is true, it logs to the browser console as well.
      */
     public function setLogger(): void
     {

phpmyfaq/src/phpMyFAQ/Configuration.php

@@ -19,14 +19,16 @@
 
 namespace phpMyFAQ;
 
+use Monolog\Handler\StreamHandler;
+use Monolog\Logger;
 use Symfony\Component\Dotenv\Dotenv;
+use Symfony\Component\ErrorHandler\Debug;
+use Symfony\Component\ErrorHandler\ErrorHandler;
 
 class Environment
 {
     private static bool $debugMode = false;
 
-    private static int $debugLevel = 0;
-
     private static bool $debugLogQueries = false;
 
     private static bool $initialized = false;
@@ -56,20 +58,9 @@ public static function enableTestMode(): void
         self::$testMode = true;
     }
 
-    public static function reset(): void
-    {
-        self::$debugMode = false;
-        self::$debugLevel = 0;
-        self::$debugLogQueries = false;
-        self::$initialized = false;
-        self::$environment = 'production';
-        self::$testMode = false;
-        self::$dotenv = null;
-    }
-
     private static function loadEnvironment(): void
     {
-        $envPath = dirname(__DIR__, 2);
+        $envPath = dirname(__DIR__, levels: 2);
         $envFile = $envPath . '/.env';
 
         if (file_exists($envFile)) {
@@ -80,37 +71,43 @@ private static function loadEnvironment(): void
 
     private static function setupDebugMode(): void
     {
+        if (self::$testMode) {
+            return;
+        }
+
         self::$debugMode = filter_var($_ENV['DEBUG'] ?? false, FILTER_VALIDATE_BOOLEAN);
-        self::$debugLevel = (int) ($_ENV['DEBUG_LEVEL'] ?? 0);
         self::$debugLogQueries = filter_var($_ENV['DEBUG_LOG_QUERIES'] ?? false, FILTER_VALIDATE_BOOLEAN);
         self::$environment = $_ENV['APP_ENV'] ?? 'production';
 
-        // Legacy support
-        if (!defined('DEBUG')) {
-            define('DEBUG', self::$debugMode);
-        }
+        error_reporting(self::$debugMode ? E_ALL : E_ERROR | E_WARNING | E_PARSE);
 
-        // Error reporting based on debug mode
         if (self::$debugMode) {
-            ini_set('display_errors', '1');
-            ini_set('display_startup_errors', '1');
-            error_reporting(E_ALL);
-        } else {
-            ini_set('display_errors', '0');
-            error_reporting(E_ERROR | E_WARNING | E_PARSE);
+            Debug::enable();
+            ErrorHandler::register();
+            return;
         }
+
+        $handler = ErrorHandler::register();
+
+        $logger = new Logger(name: 'phpmyfaq');
+        $logTarget = $_ENV['ERROR_LOG'] ?? 'php://stderr';
+        $logger->pushHandler(new StreamHandler($logTarget, Logger::WARNING));
+
+        $levelsMap = [
+            E_DEPRECATED => null,
+            E_USER_DEPRECATED => null,
+        ];
+        $handler->setDefaultLogger($logger, $levelsMap);
+
+        $handler->screamAt(E_ALL & ~E_DEPRECATED & ~E_USER_DEPRECATED);
+        $handler->scopeAt(E_ALL & ~E_DEPRECATED & ~E_USER_DEPRECATED);
     }
 
     public static function isDebugMode(): bool
     {
         return self::$debugMode;
     }
 
-    public static function getDebugLevel(): int
-    {
-        return self::$debugLevel;
-    }
-
     public static function shouldLogQueries(): bool
     {
         return self::$debugLogQueries;