SCAL-229730-test worksheet Id not provided spotter (#44)

Author: yinstardev

src/embed/conversation.spec.ts

@@ -14,6 +14,7 @@ import {
     defaultParamsWithoutHiddenActions as defaultParams,
     expectUrlMatchesWithParams,
 } from '../test/test-utils';
+import { ERROR_MESSAGE } from '../errors';
 
 const thoughtSpotHost = 'tshost';
 
@@ -43,4 +44,19 @@ describe('ConversationEmbed', () => {
             `http://${thoughtSpotHost}/v2/?${defaultParams}&isSpotterExperienceEnabled=true#/embed/insights/conv-assist?worksheet=worksheetId&query=searchQuery`,
         );
     });
+
+    it('should handle error when worksheetId is not provided', async () => {
+        const viewConfig: ConversationViewConfig = {
+            worksheetId: '',
+            searchOptions: {
+                searchQuery: 'searchQuery',
+            },
+        };
+        const conversationEmbed = new ConversationEmbed(getRootEl(), viewConfig);
+        (conversationEmbed as any).handleError = jest.fn();
+        await conversationEmbed.render();
+        expect((conversationEmbed as any).handleError).toHaveBeenCalledWith(
+            ERROR_MESSAGE.SPOTTER_EMBED_WORKSHEED_ID_NOT_FOUND,
+        );
+    });
 });

src/embed/conversation.ts

@@ -1,3 +1,4 @@
+import { ERROR_MESSAGE } from '../errors';
 import { ViewConfig, Param } from '../types';
 import { TsEmbed } from './ts-embed';
 import { getQueryParamString } from '../utils';
@@ -49,6 +50,9 @@ export class ConversationEmbed extends TsEmbed {
             searchOptions,
         } = this.viewConfig;
         const path = 'insights/conv-assist';
+        if (!worksheetId) {
+            this.handleError(ERROR_MESSAGE.SPOTTER_EMBED_WORKSHEED_ID_NOT_FOUND);
+        }
         const queryParams = this.getBaseQueryParams();
         queryParams[Param.SpotterEnabled] = true;
 

src/errors.ts

@@ -1,5 +1,6 @@
 export const ERROR_MESSAGE = {
     INVALID_THOUGHTSPOT_HOST: 'Error parsing ThoughtSpot host. Please provide a valid URL.',
+    SPOTTER_EMBED_WORKSHEED_ID_NOT_FOUND: 'Please select a worksheet to get started',
     LIVEBOARD_VIZ_ID_VALIDATION: 'Please select a Liveboard to embed.',
     TRIGGER_TIMED_OUT: 'Trigger timed-out in getting a response',
     SEARCHEMBED_BETA_WRANING_MESSAGE: 'SearchEmbed is in Beta in this release.',