Skip to content

Commit 1880a48

Browse files
topeposimonpcouch
andauthored
Fail on NULL engine (#1248)
* changes to #1242 * updated test cases * Update R/engines.R Co-authored-by: Simon P. Couch <[email protected]> * rerun tests and redoc * skip for upcoming dials release --------- Co-authored-by: Simon P. Couch <[email protected]>
1 parent 8448c06 commit 1880a48

21 files changed

+46
-23
lines changed

NEWS.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@
4747

4848
* The quantile regression prediction type was disabled for the deprecated `surv_reg()` model.
4949

50+
* `NULL` is no longer accepted as an engine (#1242).
51+
5052

5153
# parsnip 1.2.1
5254

R/engines.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ set_engine <- function(object, engine, ...) {
111111
set_engine.model_spec <- function(object, engine, ...) {
112112
mod_type <- class(object)[1]
113113

114-
if (rlang::is_missing(engine)) {
114+
if (rlang::is_missing(engine) || is.null(engine)) {
115115
stop_missing_engine(mod_type, call = caller_env(0))
116116
}
117117
object$engine <- engine

man/details_linear_reg_glmer.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/details_linear_reg_lmer.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/details_linear_reg_stan_glmer.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/details_logistic_reg_glmer.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/details_logistic_reg_stan_glmer.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/details_poisson_reg_glmer.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/details_poisson_reg_stan_glmer.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/parsnip-package.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)