Add/update tests for model/data mode mismatch

Author: juliasilge

tests/testthat/test_boost_tree_xgboost.R

@@ -122,6 +122,16 @@ test_that('xgboost execution, regression', {
     ),
     regexp = NA
   )
+
+  expect_error(
+    res <- parsnip::fit_xy(
+      car_basic,
+      x = mtcars[, num_pred],
+      y = factor(mtcars$vs),
+      control = ctrl
+    ),
+    regexp = "For a regression model"
+  )
 })
 
 

tests/testthat/test_linear_reg.R

@@ -241,6 +241,16 @@ test_that('lm execution', {
     regexp = NA
   )
 
+  expect_error(
+    res <- fit_xy(
+      hpc_basic,
+      x = hpc[, num_pred],
+      y = hpc$class,
+      control = ctrl
+    ),
+    regexp = "For a regression model"
+  )
+
   expect_error(
     res <- fit(
       hpc_basic,
@@ -250,13 +260,15 @@ test_that('lm execution', {
     )
   )
 
-  lm_form_catch <- fit(
-    hpc_basic,
-    hpc_bad_form,
-    data = hpc,
-    control = caught_ctrl
+  expect_error(
+    lm_form_catch <- fit(
+      hpc_basic,
+      hpc_bad_form,
+      data = hpc,
+      control = caught_ctrl
+    ),
+    regexp = "For a regression model"
   )
-  expect_true(inherits(lm_form_catch$fit, "try-error"))
 
   ## multivariate y
 

tests/testthat/test_mars.R

@@ -151,16 +151,14 @@ test_that('mars execution', {
   expect_true(has_multi_predict(res))
   expect_equal(multi_predict_args(res), "num_terms")
 
-  expect_message(
-    expect_error(
-      res <- fit(
-        hpc_basic,
-        hpc_bad_form,
-        data = hpc,
-        control = ctrl
-      )
+  expect_error(
+    res <- fit(
+      hpc_basic,
+      hpc_bad_form,
+      data = hpc,
+      control = ctrl
     ),
-    "Timing stopped"
+    regexp = "For a regression model"
   )
 
   ## multivariate y
@@ -203,7 +201,7 @@ test_that('mars prediction', {
            input_fields =
              c(430.476046435458, 158.833790342308, 218.07635084308,
                158.833790342308, 158.833790342308)
-           ),
+      ),
       class = "data.frame", row.names = c(NA, -5L)
     )
 

tests/testthat/test_rand_forest_ranger.R

@@ -37,6 +37,16 @@ test_that('ranger classification execution', {
   )
   expect_output(print(res), "parsnip model object")
 
+  expect_error(
+    res <- fit(
+      lc_ranger,
+      funded_amnt ~ Class + term,
+      data = lending_club,
+      control = ctrl
+    ),
+    regexp = "For a classification model"
+  )
+
   expect_error(
     res <- fit_xy(
       lc_ranger,