code review comments

Author: sierrajohnson

NEWS.md

@@ -5,7 +5,7 @@
 * Fixed regression where `draw_key_rect()` stopped using `fill` colours 
   (@mitchelloharawild, #6609).
 
-### Improvements
+
 * Allow `stat` in `geom_hline`, `geom_vline`, and `geom_abline`. (@sierrajohnson, #6559)
 
 # ggplot2 4.0.0

R/geom-abline.R

@@ -69,12 +69,12 @@ NULL
 #'   geom_hline(aes(yintercept = wt, colour = wt), mean_wt) +
 #'   facet_wrap(~ cyl)
 geom_abline <- function(mapping = NULL, data = NULL,
+                        stat = "identity", 
                         ...,
                         slope,
                         intercept,
                         na.rm = FALSE,
                         show.legend = NA,
-                        stat = "identity",
                         inherit.aes = FALSE) {
 
   # If nothing set, default to y = x

R/geom-hline.R

@@ -4,12 +4,11 @@ NULL
 #' @export
 #' @rdname geom_abline
 geom_hline <- function(mapping = NULL, data = NULL,
-                       position = "identity",
+                       stat = "identity", position = "identity",
                        ...,
                        yintercept,
                        na.rm = FALSE,
                        show.legend = NA,
-                      stat = "identity",
                       inherit.aes = FALSE) {
 
   # Act like an annotation

R/geom-vline.R

@@ -4,12 +4,11 @@ NULL
 #' @export
 #' @rdname geom_abline
 geom_vline <- function(mapping = NULL, data = NULL,
-                       position = "identity",
+                      stat = "identity", position = "identity",
                        ...,
                        xintercept,
                        na.rm = FALSE,
                        show.legend = NA,
-                      stat = "identity",
                       inherit.aes = FALSE) {
 
   # Act like an annotation