Merge branch 'master' into fix-invalid-modified-state-on-initialization

# Via GitHub (1) and Larry Botha (1)
* master:
  fix(error initialisation): ensure array values in initialValues are represented in errors
  fix(error initialization): fix array values in schema validation being returned as strings
  test(async test): use 'done' callback to notify jest of test completion
  chore(package-lock.json): update
  style(various files): whitespace

# Conflicts:
#	lib/create-form.js
#	lib/util.js
#	package-lock.json
#	test/library.spec.js

Author: Larry Botha

lib/create-form.js

@@ -19,7 +19,7 @@ export const createForm = (config) => {
     values: () => util.cloneDeep(initialValues),
     errors: () =>
       validationSchema
-        ? util.getErrorsFromSchema(validationSchema.fields)
+        ? util.getErrorsFromSchema(initialValues, validationSchema.fields)
         : util.assignDeep(initialValues, NO_ERROR),
     touched: () => util.assignDeep(initialValues, !IS_TOUCHED),
   };

lib/util.js

@@ -36,15 +36,37 @@ function getValues(object) {
   return result;
 }
 
-function getErrorsFromSchema(schema, errors = {}) {
+// TODO: refactor this so as not to rely directly on yup's API
+// This should use dependency injection, with a default callback which may assume
+// yup as the validation schema
+function getErrorsFromSchema(initialValues, schema, errors = {}) {
   for (const key in schema) {
-    if (schema[key].type === 'object' && !isEmpty(schema[key].fields)) {
-      errors[key] = getErrorsFromSchema(
-        schema[key].fields,
-        Object.assign({}, errors),
-      );
-    } else {
-      errors[key] = '';
+    switch (true) {
+      case schema[key].type === 'object' && !isEmpty(schema[key].fields): {
+        errors[key] = getErrorsFromSchema(
+          initialValues[key],
+          schema[key].fields,
+          Object.assign({}, errors[key]),
+        );
+        break;
+      }
+
+      case schema[key].type === 'array': {
+        const values =
+          initialValues && initialValues[key] ? initialValues[key] : [];
+        errors[key] = values.map((value) =>
+          getErrorsFromSchema(
+            value,
+            schema[key].innerType.fields,
+            Object.assign({}, errors[key]),
+          ),
+        );
+        break;
+      }
+
+      default: {
+        errors[key] = '';
+      }
     }
   }