feat: use shutil.rmtree to remove cache

Co-authored-by: Vitor Henrique <[email protected]>
Signed-off-by: K.B.Dharun Krishna <[email protected]>

Author: kbdharun

README.md

@@ -43,7 +43,7 @@ sudo snap install tldr
 
 ## Usage
 
-```txt
+```bash
 usage: tldr command [options]
 
 Python command line client for tldr
@@ -57,8 +57,7 @@ options:
   --search "KEYWORDS"   Search for a specific command from a query
   -u, --update, --update_cache
                         Update the local cache of pages and exit
-  -k, --clear-cache
-                        Delete the local cache of pages and exit
+  -k, --clear-cache     Delete the local cache of pages and exit
   -p PLATFORM, --platform PLATFORM
                         Override the operating system [android, freebsd, linux, netbsd, openbsd, osx, sunos, windows, common]
   -l, --list            List all available commands for operating system
@@ -69,6 +68,8 @@ options:
   -L LANGUAGE, --language LANGUAGE
                         Override the default language
   -m, --markdown        Just print the plain page file.
+  --short-options       Display shortform options over longform
+  --long-options        Display longform options over shortform
   --print-completion {bash,zsh,tcsh}
                         print shell completion script
 ```
@@ -109,7 +110,8 @@ In order of precedence:
 - `~/.cache/tldr`
 
 If you are experiencing issues with *tldr*, consider deleting the cache files before trying other measures:
-```
+
+```bash
 tldr --clear-cache
 ```
 
@@ -144,7 +146,7 @@ will disable SSL certificate inspection. This __should be avoided__ unless absol
 
 Alternatively, It is possible to use a different certificate store/bundle by setting:
 
-* `TLDR_CERT=/path/to/certificates.crt`
+- `TLDR_CERT=/path/to/certificates.crt`
 
 ### Colors
 

tldr.py

@@ -16,6 +16,7 @@
 from urllib.error import HTTPError, URLError
 from termcolor import colored
 import shtab
+import shutil
 
 __version__ = "3.3.0"
 __client_specification__ = "2.2"
@@ -550,25 +551,8 @@ def clear_cache(language: Optional[List[str]] = None) -> None:
         pages_dir = f'pages.{language}' if language != 'en' else 'pages'
         cache_dir = get_cache_dir() / pages_dir
         if cache_dir.exists() and cache_dir.is_dir():
-            # Recursively walk through the directory to delete files and subdirectories
-            for root, dirs, files in os.walk(cache_dir, topdown=False):
-                for name in files:
-                    file_path = Path(root) / name
-                    try:
-                        file_path.unlink()  # Attempt to delete the file
-                    except Exception as e:
-                        print(f"Error: Unable to delete cache file {file_path}: {e}")
-                for name in dirs:
-                    dir_path = Path(root) / name
-                    try:
-                        dir_path.rmdir()  # Attempt to delete the directory
-                    except Exception as e:
-                        print(
-                            f"Error: Unable to delete cache directory {dir_path}: {e}"
-                        )
-            # Attempt to remove the main cache directory after clearing its contents
             try:
-                cache_dir.rmdir()
+                shutil.rmtree(cache_dir)
                 print(f"Cleared cache for language {language}")
             except Exception as e:
                 print(f"Error: Unable to delete cache directory {cache_dir}: {e}")