Bug: Unable to download or update tldr pages

[manudoni-hubcore]

Bug

tldr --update fails because https://tldr.sh/assets/tldr.zip returns an HTML redirect instead of a ZIP archive

Description

After installing the latest version of the Python client (tldr 3.4.4), updating the local cache fails with the following error:

$ tldr --update
Downloading tldr pages to /home/<user>/.local/share/tldr
tldr: Data.Binary.Get.runGet at position 4: Did not find end of central directory signature
CallStack (from HasCallStack):
  error, called at libraries/binary/src/Data/Binary/Get.hs:345:5 in binary-0.8.9.1:Data.Binary.Get

Environment

• OS: Ubuntu 24.04 running under WSL2
• Installation method: pipx
• Python: 3.12.3
• tldr: 3.4.4

Investigation

The issue appears to be caused by the download URL used for the page archive.

Running:

curl -L -o /tmp/tldr.zip https://tldr.sh/assets/tldr.zip

does not download a ZIP archive.

Instead, it downloads an HTML page containing:

<meta http-equiv="refresh" content="0;url=https://github.com/tldr-pages/tldr/releases/latest/download/tldr.zip">

As a result:

$ file /tmp/tldr.zip
/tmp/tldr.zip: HTML document, ASCII text

$ unzip -t /tmp/tldr.zip
End-of-central-directory signature not found.

The client then attempts to parse this HTML file as a ZIP archive and fails with the error shown above.

Expected behavior

The update process should either:

• download the archive directly from GitHub Releases, or
• detect that the downloaded content is HTML instead of a ZIP archive and report a meaningful error.

[owenvoke]

The URL for the ZIP here hasn't been using tldr.sh for over 2 years. 🤔 Is your TLDR_DOWNLOAD_CACHE_LOCATION env set?

However, I'd assume this is related to the change in tldr-pages/tldr-pages.github.io@ef397b1, where a redirect was added.

Just to mention, I ran pipx run tldr --update locally, and it worked as expected.

[manudoni-hubcore]

I don't have the env TLDR_DOWNLOAD_CACHE_LOCATION set

[manudoni-hubcore]

I run pipx run tldr --update as you said and it downloaded successfully the pages.
The command I used to run was tldr --update, now that also is working