fix(wl-copy): assume mime text/plain, avoid clipboard manager refusin… #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g to paste If we don't supply a `text/plain` mime-type to `wl-copy` it will constantly assume types from text that can be problematic for some clipboard managers to handle. In this case clipboard manager such as https://invent.kde.org/plasma/plasma-workspace/-/tree/master/klipper Is strict and assume it is binary data (file copied) copied, which makes sense. I don't really see a need to assume anything but `text/plain` unless someone can come with a legit reason to oppose this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't supply a
text/plainmime-type towl-copyit will constantly assume types from text that can be problematic for some clipboard managers to handle.Because
wl-copydetects viaxdg-mimeif it lacks a--typearg ( https://github.com/bugaevc/wl-clipboard/blob/master/src/util/files.c#L173 )In this case clipboard manager such as https://invent.kde.org/plasma/plasma-workspace/-/tree/master/klipper
Is strict and assume it is binary data (file copied) copied, which makes sense.
I don't really see a need to assume anything but
text/plainunless someone can come with a legit reason to oppose this PR.