Skip to content

Commit 52bebec

Browse files
Merge pull request #1259 from topcoder-platform/PM-2442
PM-2442 Fix review progress bar
2 parents c29aa96 + 8e44e46 commit 52bebec

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

src/apps/review/src/lib/hooks/useFetchScreeningReview.ts

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { EnvironmentConfig } from '~/config'
66
import { getRatingColor, xhrGetAsync } from '~/libs/core'
77
import { handleError } from '~/libs/shared'
88

9-
import { REVIEWER, SUBMITTER } from '../../config/index.config'
9+
import { DESIGN, REVIEWER, SUBMITTER } from '../../config/index.config'
1010
import { ChallengeDetailContext, ReviewAppContext } from '../contexts'
1111
import {
1212
BackendPhase,
@@ -2161,7 +2161,17 @@ export function useFetchScreeningReview(): useFetchScreeningReviewProps {
21612161
return 0
21622162
}
21632163

2164-
const completedReviews = filter(review, item => {
2164+
const isDesignChallenge = challengeInfo?.track.name === DESIGN
2165+
2166+
const filteredReviews = isDesignChallenge
2167+
? review
2168+
: review.filter(item => item.isLatest)
2169+
2170+
if (!filteredReviews.length) {
2171+
return 0
2172+
}
2173+
2174+
const completedReviews = filteredReviews.filter(item => {
21652175
const committed = item.review?.committed
21662176
if (typeof committed === 'boolean') {
21672177
return committed
@@ -2185,9 +2195,9 @@ export function useFetchScreeningReview(): useFetchScreeningReviewProps {
21852195
})
21862196

21872197
return Math.round(
2188-
(completedReviews.length * 100) / review.length,
2198+
(completedReviews.length * 100) / filteredReviews.length,
21892199
)
2190-
}, [review])
2200+
}, [review, challengeInfo])
21912201

21922202
useEffect(() => () => {
21932203
cancelLoadResourceAppeal()

0 commit comments

Comments
 (0)