PM-2133 - PR feedback

Author: vas3a

src/libs/shared/lib/components/notifications/localstorage.utils.ts

@@ -1,7 +1,9 @@
+const lsKeyPrefix = 'notificationDismissed'
+
 export const wasDismissed = (id: string): boolean => (
-    (localStorage.getItem(`dismissed[${id}]`)) !== null
+    (localStorage.getItem(`${lsKeyPrefix}[${id}]`)) !== null
 )
 
 export const dismiss = (id: string): void => {
-    localStorage.setItem(`dismissed[${id}]`, JSON.stringify(true))
+    localStorage.setItem(`${lsKeyPrefix}[${id}]`, JSON.stringify(true))
 }

src/libs/ui/lib/components/notification/Notification.tsx

@@ -15,7 +15,7 @@ interface NotificationProps {
 const Notification: FC<NotificationProps> = props => {
     const handleClose = useCallback((save?: boolean) => {
         props.onClose(props.notification.id, save)
-    }, [props.onClose])
+    }, [props.onClose, props.notification.id])
 
     if (props.notification.type === 'banner') {
         return (

src/libs/ui/lib/components/notification/banner/NotificationBanner.stories.tsx

@@ -5,11 +5,11 @@ import NotificationBanner from './NotificationBanner'
 const meta: Meta<typeof NotificationBanner> = {
     argTypes: {
         content: {
-            description: 'Content displayed inside the tooltip',
+            description: 'Content displayed inside the notification banner',
         },
         persistent: {
             defaultValue: false,
-            description: 'Set to true to allow clicks inside the tooltip',
+            description: 'Set to true to hide the close icon button',
         },
     },
     component: NotificationBanner,