Skip to content

Commit ebb3f1f

Browse files
committed
PROD-3560 - update how we show hover menu
1 parent f429138 commit ebb3f1f

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

src/lib/components/LinksMenu.svelte

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,6 @@
1717
}
1818
1919
const handleMouseover = (menuItem: NavMenuItem) => async (ev) => {
20-
if (activeRoute) {
21-
return;
22-
}
23-
2420
if (!itemHasHoverMenu(menuItem)) {
2521
return;
2622
}

src/lib/marketing-navigation/MarketingNavigation.svelte

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
style='primary'
4141
menuItems={menuItems}
4242
isMobile={$isMobile}
43+
showHoverMenu={!primaryRoute}
4344
>
4445
<svelte:fragment slot="auth">
4546
<AboutUsMenuItem />
@@ -53,6 +54,7 @@
5354
activeRoute={secondaryRoute}
5455
style='secondary'
5556
menuItems={primaryRoute.children}
57+
showHoverMenu={!secondaryRoute?.children?.length}
5658
/>
5759
{/if}
5860

src/lib/marketing-navigation/components/NavigationBar.svelte

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
export let activeRoutePath: NavMenuItem[] = [];
1111
export let activeRoute: NavMenuItem;
1212
export let isMobile: boolean = false;
13+
export let showHoverMenu: boolean = true;
1314
1415
let popupIsVisible: boolean;
1516
let hoveredElement: HTMLElement | undefined;
@@ -31,7 +32,7 @@
3132
isPopupMenuActive={popupIsVisible}
3233
style={style}
3334
>
34-
{#if !activeRoute}
35+
{#if showHoverMenu}
3536
<HoverMenu
3637
menuItems={hoveredMenuItem?.children}
3738
mainDescription={hoveredMenuItem?.description}

0 commit comments

Comments
 (0)