Remove legacy challenge block when launching challenges

Author: jmgasper

src/components/ChallengeEditor/ChallengeViewTabs/index.js

@@ -210,18 +210,11 @@ const ChallengeViewTabs = ({
             (<div className={styles['cancel-button']}><CancelDropDown challenge={challenge} onSelectMenu={cancelChallenge} /></div>)}
           {canLaunch && (
             <div className={styles.button}>
-              {challenge.legacyId || isTask ? (
-                <PrimaryButton
-                  text='Launch'
-                  type='info'
-                  onClick={onLaunchChallenge}
-                />
-              ) : (
-                <Tooltip content={MESSAGE.NO_LEGACY_CHALLENGE}>
-                  {/* Don't disable button for real inside tooltip, otherwise mouseEnter/Leave events work not good */}
-                  <PrimaryButton text={'Launch'} type={'disabled'} />
-                </Tooltip>
-              )}
+              <PrimaryButton
+                text='Launch'
+                type='info'
+                onClick={onLaunchChallenge}
+              />
             </div>
           )}
           {canApprove && (

src/components/ChallengeEditor/index.js

@@ -1595,13 +1595,10 @@ class ChallengeEditor extends Component {
                   !preventCopilotFromActivatingTask
                 ) && (
                   <div className={styles.button}>
-                    {(challenge.legacyId || isTask) && !this.state.hasValidationErrors ? (
+                    {!this.state.hasValidationErrors ? (
                       <PrimaryButton text={'Launch as Active'} type={'info'} onClick={this.toggleLaunch} />
                     ) : (
-                      <Tooltip content={MESSAGE.NO_LEGACY_CHALLENGE}>
-                        {/* Don't disable button for real inside tooltip, otherwise mouseEnter/Leave events work not good */}
-                        <PrimaryButton text={'Launch as Active'} type={'disabled'} />
-                      </Tooltip>
+                      <PrimaryButton text={'Launch as Active'} type={'disabled'} />
                     )}
                   </div>
                 )

src/components/ChallengesComponent/ChallengeCard/index.js

@@ -4,20 +4,18 @@
 import _ from 'lodash'
 import React from 'react'
 import PropTypes from 'prop-types'
-import cn from 'classnames'
 import { withRouter, Link } from 'react-router-dom'
 import moment from 'moment'
 import 'moment-duration-format'
 import ChallengeStatus from '../ChallengeStatus'
 import ChallengeTag from '../ChallengeTag'
 import styles from './ChallengeCard.module.scss'
 import { formatDate } from '../../../util/date'
-import { CHALLENGE_STATUS, COMMUNITY_APP_URL, DIRECT_PROJECT_URL, MESSAGE, ONLINE_REVIEW_URL, PROJECT_ROLES } from '../../../config/constants'
+import { CHALLENGE_STATUS, COMMUNITY_APP_URL, DIRECT_PROJECT_URL, ONLINE_REVIEW_URL, PROJECT_ROLES } from '../../../config/constants'
 import ConfirmationModal from '../../Modal/ConfirmationModal'
 import { checkChallengeEditPermission, checkReadOnlyRoles } from '../../../util/tc'
 import { getCurrentPhase } from '../../../util/phase'
 import AlertModal from '../../Modal/AlertModal'
-import Tooltip from '../../Tooltip'
 
 const theme = {
   container: styles.modalContainer
@@ -47,11 +45,13 @@ const hoverComponents = (challenge, onUpdateLaunch, deleteModalLaunch) => {
     )
   }
 
-  return challenge.legacyId || isTask ? (
+  const showLegacyLinks = Boolean(challenge.legacyId) && !isTask
+
+  return (
     <div className={styles.linkGroup}>
       <div className={styles.linkGroupLeft}>
         <a className={styles.link} href={communityAppUrl} target='_blank'>View Challenge</a>
-        {!isTask && (
+        {showLegacyLinks && (
           <div className={styles.linkGroupLeftBottom}>
             <a className={styles.link} href={directUrl} target='_blank'>Direct</a>
             <span className={styles.linkDivider}>|</span>
@@ -65,33 +65,6 @@ const hoverComponents = (challenge, onUpdateLaunch, deleteModalLaunch) => {
         </button>
       )}
     </div>
-  ) : (
-    <div className={styles.linkGroup}>
-      <div className={styles.linkGroupLeft}>
-        <a className={styles.link} href={communityAppUrl}>View Challenge</a>
-        {!isTask && (
-          <div className={styles.linkGroupLeftBottom}>
-            <Tooltip content={MESSAGE.NO_LEGACY_CHALLENGE}>
-              <span className={styles.link}>Direct</span>
-            </Tooltip>
-            <span className={styles.linkDivider}>|</span>
-            <Tooltip content={MESSAGE.NO_LEGACY_CHALLENGE}>
-              <span className={styles.link}>OR</span>
-            </Tooltip>
-          </div>
-        )}
-      </div>
-      {
-        challenge.status === 'Draft' && (
-          <Tooltip content={MESSAGE.NO_LEGACY_CHALLENGE}>
-            {/* Don't disable button for real inside tooltip, otherwise mouseEnter/Leave events work not good */}
-            <button className={cn(styles.activateButton, styles.activateButtonDisabled)}>
-              <span>Activate</span>
-            </button>
-          </Tooltip>
-        )
-      }
-    </div>
   )
 }
 

src/components/LegacyLinks/index.js

@@ -5,8 +5,7 @@ import React, { useCallback } from 'react'
 import PropTypes from 'prop-types'
 import cn from 'classnames'
 import styles from './LegacyLinks.module.scss'
-import Tooltip from '../Tooltip'
-import { MESSAGE, ONLINE_REVIEW_URL } from '../../config/constants'
+import { ONLINE_REVIEW_URL } from '../../config/constants'
 
 const LegacyLinks = ({ challenge, challengeView }) => {
   const onClick = useCallback((e) => {
@@ -16,12 +15,11 @@ const LegacyLinks = ({ challenge, challengeView }) => {
   const orUrl = `${ONLINE_REVIEW_URL}/review/actions/ViewProjectDetails?pid=${challenge.legacyId}`
   return (
     <div className={styles.container}>
-      (  {challenge.legacyId ? <a href={orUrl} target={'_blank'} onClick={onClick}>Online Review</a>
-        : <Tooltip content={MESSAGE.NO_LEGACY_CHALLENGE}>
-          {/* Don't disable button for real inside tooltip, otherwise mouseEnter/Leave events work not good */}
-          <a disabled>Online Review</a>
-        </Tooltip>}
-      )
+      {challenge.legacyId && (
+        <>
+          (<a href={orUrl} target={'_blank'} onClick={onClick}>Online Review</a>)
+        </>
+      )}
       <div>
         { challengeView && challenge.discussions && challenge.discussions.map(d => (
           <div key={d.id} className={cn(styles.row, styles.topRow)}>

src/config/constants.js

@@ -378,7 +378,6 @@ export const CHALLENGE_TYPES_WITH_MULTIPLE_PRIZES = ['Challenge', 'Marathon Matc
  * To have the same wording across the app.
  */
 export const MESSAGE = {
-  NO_LEGACY_CHALLENGE: 'Legacy challenge is not yet created',
   NO_TASK_ASSIGNEE: 'Task is not assigned yet',
   TASK_CLOSE_SUCCESS: 'Task closed successfully',
   CHALLENGE_LAUNCH_SUCCESS: 'Challenge activated successfully',